Skip to content

Commit

Permalink
build: remove LOG_DEBUG option
Browse files Browse the repository at this point in the history
Its usecase is too specific to warrant an option. The same effect can be
achieved by passing `-DCMAKE_C_FLAGS=-DNVIM_LOG_DEBUG` in the command
line when building neovim.
  • Loading branch information
dundargoc authored May 28, 2023
1 parent 03a2c5b commit 8206954
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ endif()
option(LOG_LIST_ACTIONS "Add list actions logging" OFF)

option(ENABLE_ASAN_UBSAN "Enable Clang address & undefined behavior sanitizer for nvim binary." OFF)
option(LOG_DEBUG "Enable debug log messages even in a release build" OFF)
option(ENABLE_MSAN "Enable Clang memory sanitizer for nvim binary." OFF)
option(ENABLE_TSAN "Enable Clang thread sanitizer for nvim binary." OFF)

Expand Down
3 changes: 0 additions & 3 deletions src/nvim/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,6 @@ endif()
if($ENV{CI})
# Don't debug log on CI, it gets too verbose in the main build log.
# TODO(bfredl): debug log level also exposes some errors with EXITFREE in ASAN build.
set(LOG_DEBUG FALSE)
elseif(LOG_DEBUG)
target_compile_definitions(nvim PRIVATE NVIM_LOG_DEBUG)
else()
# Minimize logging for release-type builds.
target_compile_definitions(nvim PRIVATE $<$<CONFIG:Debug>:NVIM_LOG_DEBUG>)
Expand Down

0 comments on commit 8206954

Please sign in to comment.