Catch and log failure to set TCP_NODELAY

Setting TCP_NODELAY may fail. Instead of failing the routine, log it and continue. It seems, that setting TCP_NODELAY in python on Mac OS X is not necessarily supported.
ciaran2 · May 25, 2015 · abe4c7c · abe4c7c
1 parent 326b4c4
commit abe4c7c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/python/nghttp2.pyx b/python/nghttp2.pyx
@@ -1238,7 +1238,10 @@ if asyncio:
 
             self.transport = transport
             sock = self.transport.get_extra_info('socket')
-            sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
+            try:
+                sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
+            except OSError as e:
+                logging.info('failed to set tcp-nodelay: %s', str(e))
             ssl_ctx = self.transport.get_extra_info('sslcontext')
             if ssl_ctx:
                 protocol = sock.selected_npn_protocol()