Fix bug in StarWars

circuithub · Feb 24, 2019 · b3f749b · b3f749b
1 parent e36fcef
commit b3f749b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -153,4 +153,7 @@ the `fake` library.
 * nation - multibyte
 * phone_number
 * restaurant
-* Write test for science - element
+* stripe
+* Write test for university - name
+* vehicle -
+* world_cup
diff --git a/src/Faker/Provider/StarWars.hs b/src/Faker/Provider/StarWars.hs
@@ -99,7 +99,7 @@ resolveStarWarsText settings txt = do
 
 resolveStarWarsField ::
      (MonadThrow m, MonadIO m) => FakerSettings -> Text -> m Text
-resolveStarWarsField settings "call_numbers" =
+resolveStarWarsField settings "call_number" =
   randomUnresolvedVec settings starWarsCall_numbersProvider resolveStarWarsText
 resolveStarWarsField settings "call_sign" =
   randomUnresolvedVec settings starWarsCall_signProvider resolveStarWarsText

diff --git a/test/FakerSpec.hs b/test/FakerSpec.hs
@@ -24,6 +24,8 @@ import Faker.File
 import Faker.Food
 import Faker.Internal
 import Faker.Provider.Educator
+import qualified Faker.Science as FS
+import Faker.StarWars
 import Test.Hspec
 
 isText :: Text -> Bool
@@ -63,3 +65,13 @@ spec = do
     it "Food" $ do
       ctries <- generate dish
       ctries `shouldSatisfy` isText
+    it "Science" $ do
+      item <- generate FS.element
+      item `shouldSatisfy` isText
+    it "StarWars" $ do
+      item <- generate call_numbers
+      item `shouldSatisfy` isText
+    it "StarWars (2)" $ do
+      item <- generate call_sign
+      print item
+      item `shouldSatisfy` isText