Fix issue with PaginatedGui's bindings not being cleared on redraw (l…

…ucko#5)
cjcameron92 · Nov 19, 2017 · ca8e8c3 · ca8e8c3
1 parent cbd95ed
commit ca8e8c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/helper/pom.xml b/helper/pom.xml
@@ -12,7 +12,7 @@
 
     <artifactId>helper</artifactId>
     <packaging>jar</packaging>
-    <version>3.1.5</version>
+    <version>3.1.6</version>
 
     <name>helper</name>
     <description>A utility to reduce boilerplate code in Bukkit plugins.</description>

diff --git a/helper/src/main/java/me/lucko/helper/menu/paginated/PaginatedGui.java b/helper/src/main/java/me/lucko/helper/menu/paginated/PaginatedGui.java
@@ -91,6 +91,7 @@ public void redraw() {
             // can't go back further
             // remove the item if the current slot contains a previous page item type
             Slot slot = getSlot(previousPageSlot);
+            slot.clearBindings();
             if (slot.hasItem() && slot.getItem().getType() == previousPageItem.apply(PageInfo.create(0, 0)).getType()) {
                 slot.clearItem();
             }
@@ -106,6 +107,7 @@ public void redraw() {
             // can't go forward a page
             // remove the item if the current slot contains a next page item type
             Slot slot = getSlot(nextPageSlot);
+            slot.clearBindings();
             if (slot.hasItem() && slot.getItem().getType() == nextPageItem.apply(PageInfo.create(0, 0)).getType()) {
                 slot.clearItem();
             }