Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Sqlalchemy errors from prior harvest rollbacks #445

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Avoid Sqlalchemy errors from prior harvest rollbacks #445

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
322110e
Validate before DB transaction boundary
bonnland May 18, 2021
18befbc
Avoid InvalidRequestError and connection timeouts
bonnland May 20, 2021
07c371e
Merge branch 'fix-validation' of https://github.com/bonnland/ckanext-…
bonnland May 20, 2021
ef23ce6
Revert ckanharvester code
bonnland May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ckanext/harvest/model/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ def create(cls, message, object, stage=u'Fetch', line=None):
# Clear any in-progress sqlalchemy transactions
try:
Session.rollback()
Session.close()
Copy link
Contributor Author

@bonnland bonnland May 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if Session.remove() is somehow different/better than Session.close().

except Exception:
pass
try:
Expand Down