Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to vscode builtin cuda-cpp language #259

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Move to vscode builtin cuda-cpp language #259

merged 2 commits into from
Nov 29, 2021

Conversation

cloudhan
Copy link
Contributor

Bulitin cuda language was added in microsoft/vscode@95420b3

@@ -25,7 +25,7 @@
"activationEvents": [
"onLanguage:c",
"onLanguage:cpp",
"onLanguage:cuda",
"onLanguage:cuda-cpp",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is available in vscode 1.56.0 or later. We need to bump the required vscode version (on Line 11).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I also updated the package @types/vscode package to match the this version.

@cloudhan cloudhan requested a review from hokein November 29, 2021 11:14
Copy link
Collaborator

@hokein hokein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hokein hokein merged commit b768b01 into clangd:master Nov 29, 2021
@cloudhan cloudhan deleted the use-langauge-cuda-cpp branch April 2, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants