Clean up the ugliest unit test ever

This volume-validation test was a disaster. Better now, if longer to scroll-through.
clhodapp · Aug 1, 2016 · ef4bccf · ef4bccf
1 parent 54e92bb
commit ef4bccf
Show file tree

Hide file tree

Showing 2 changed files with 936 additions and 265 deletions.
diff --git a/pkg/api/validation/validation.go b/pkg/api/validation/validation.go
@@ -778,6 +778,7 @@ func validateLocalDescendingPath(targetPath string, fldPath *field.Path) field.E
 	for _, item := range parts {
 		if item == ".." {
 			allErrs = append(allErrs, field.Invalid(fldPath, targetPath, "must not contain '..'"))
+			break // even for `../../..`, one error is sufficient to make the point
 		}
 	}
 	return allErrs