feat: add roboclic service #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
NoeTerrier
reviewed
Sep 5, 2023
roboclic/docker-compose.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| services: | |||
| roboclic: | |||
| image: ghrc.io/clicepfl/roboclic # TODO Check if correct | |||
There was a problem hiding this comment.
is it necessary to host the image on ghrc? Can't we keep it at home?
There was a problem hiding this comment.
Doesn't it have to be on the caddy network too ?
There was a problem hiding this comment.
Can't we keep it at home?
We could, but we would need to self-host a docker registry. Since the code (including the Dockerfile) is public, I don't think it is an issue if it is hosted by Github.
Doesn't it have to be on the caddy network too ?
No, since it only needs to send HTTP requests, it does not receive any.
There was a problem hiding this comment.
I think it's ghcr.io ? Remove comment as well
NoeTerrier
approved these changes
Sep 5, 2023
codeofmochi
requested changes
Sep 6, 2023
roboclic/docker-compose.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| services: | |||
| roboclic: | |||
| image: ghrc.io/clicepfl/roboclic # TODO Check if correct | |||
There was a problem hiding this comment.
I think it's ghcr.io ? Remove comment as well
NoeTerrier
approved these changes
Sep 6, 2023
codeofmochi
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9