Adds support for cljs testing and ->styled tests #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like I can't see what is happening in Circle CI - so I can't tell if what I did works - any help you can offer would be welcome :) |
|
@brianium Have you seen headless Chrome? It seems like a good new replacement for PhantomJS https://github.com/GoogleChrome/puppeteer |
|
All tests are passed! :) CI link https://circleci.com/gh/roman01la/cljss |
|
@roman01la awesome! thank you! I actually used headless Chrome and puppeteer this week for a small application. Definitely an awesome tool 👍 For the time being - it looks like we are at the mercy of the doo library. In terms of headless browsers, it looks like it only supports phantomjs, slimer, and has some alpha support for electron. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roman01la sorry for the delay - I've been busy
This is my first crack at introducing an environment for testing ClojureScript aspects of cljss.
It includes tests for
->styledto start, and includes alein test-alltask for running all tests, as well as a doo setup to test ClojureScript.I am attempting to get phantomjs installed via Circle CI as well.
Please let me know if you have comments/questions :)