Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a null check Fix issue #24 #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michelemilesi
Copy link

Fixed the issue #24 "NPE on RegexRowRule when a row field is empty"
adding a null check and test case

Fixed the issue cloudera-labs#24 "NPE on RegexRowRule when a row field is empty"
adding a null check and test case
@jeremybeard
Copy link
Contributor

@michelemilesi, thanks for raising the issue and sending over the PR to solve it. Currently the project isn't ready for public contributions so for now we are developing it internally at Cloudera and just push releases to this repository. Hopefully that will change in the near future so in the meantime I'll leave this open, though there's a chance it might get fixed first as part of our internal work.

@michelemilesi
Copy link
Author

@jeremybeard first of all thanks for your work.
I know, from Cloudera forum, that Envelope was closed for contributions (at the moment) and it sounds good for me.
If it is OK for I will open other issues and, if I can, add PR solving the problem.
I'm using Envelope in a couple of projects - on the biggest following a cloudera suggestion.

BTW it is OK for me if you will close or drop my PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants