Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reference to document into effect #23

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Move reference to document into effect #23

merged 1 commit into from
Mar 22, 2021

Conversation

third774
Copy link
Contributor

This should resolve issues with server side rendering.

#18

@third774 third774 requested review from renandincer and Everlag March 19, 2021 18:07
Everlag
Everlag approved these changes Mar 22, 2021
View reviewed changes
Copy link

@Everlag Everlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice and straightforward :)

@third774 third774 merged commit 0a003d5 into master Mar 22, 2021
@third774 third774 deleted the move-document-usage-into-effect branch March 22, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Everlag Everlag Everlag approved these changes

@renandincer renandincer Awaiting requested review from renandincer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@third774 @Everlag