Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postgres-10 from bosh release #2584

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Remove postgres-10 from bosh release #2584

merged 2 commits into from
Nov 21, 2024

Conversation

aramprice
Copy link
Member

Items of note

  • worker_ctl.erb had a reference to postgres-10/bin which was changed to postgres-13/bin; we suspect this may not be needed in $PATH
  • a warning about upgrading postgres-13 was commented out in the prestart script since we currently still support upgrades from v13

Items of note
- worker_ctl.erb had a reference to `postgres-10/bin` which was changed
  to `postgres-13/bin`; we suspect this may not be needed in $PATH
- a warning about upgrading `postgres-13` was commented out in the
  prestart script since we currently still support upgrades from v13

Signed-off-by: Brian Upton <[email protected]>
@aramprice aramprice requested review from jpalermo, a team and mingxiao and removed request for a team November 13, 2024 01:11
@jpalermo
Copy link
Member

Default was changed from 10 only 2 years ago, so this will prevent upgrades from any envs at that point.

@jpalermo jpalermo requested a review from a team November 14, 2024 15:59
@aramprice
Copy link
Member Author

Removing this package will save ~10-15 minutes of compile time.

Copy link
Member

@jpalermo jpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the version needed to upgrade. Looks like we shipped another one.

@ystros
Copy link
Contributor

ystros commented Nov 21, 2024

Updated the version in error messages for the last Postgres-10-compatible Director.

@jpalermo jpalermo merged commit 59effe1 into main Nov 21, 2024
21 checks passed
@jpalermo jpalermo deleted the remove-postgres-10 branch November 21, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants