Skip to content

Commit

Permalink
Add topcoder login prompt, remove hard-coded credentials.
Browse files Browse the repository at this point in the history
  • Loading branch information
tjpotenza committed Feb 27, 2016
1 parent 57b1c81 commit ae485cb
Show file tree
Hide file tree
Showing 8 changed files with 689 additions and 21 deletions.
27 changes: 22 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

## Configuration

`config.js` contains configuration
`OAUTH_API_KEY` the API Key from https://oauth.io/
`config.js` contains configuration
`OAUTH_API_KEY` the API Key from https://oauth.io/
`TC_ENDPOINT` the topcoder endpoint where issue details are posted, add same url to `permissions` in `manifest.json` (it must end with `*`)

### Setup github app
Expand Down Expand Up @@ -37,6 +37,23 @@


### Verification
Video https://youtu.be/rYRLGfEOGzg
It's recommended to create a new repository https://github.com/new
then go to `Issues` tab and create a new issue
Video https://youtu.be/rYRLGfEOGzg
It's recommended to create a new repository https://github.com/new
then go to `Issues` tab and create a new issue

## Prompt

Prompts the user for their TopCoder credentials, requests and saves token in
localStorage. If token is already stored locally, doesn't prompt for login.

### Modifications
- Added promptTopCoder(): Populates username and password from prompt
- Changed credentials checked within authenticateTopCoder() to new variables
- Modified checkTopCoderAuthentication() to call promptTopCoder() if user is not authenticated

### Third Party Libraries

* [Vex](http://github.hubspot.com/vex/): Used for the TopCoder Prompt
- MIT License
* [jQuery](https://jquery.org/): Dependency for Vex
- MIT License
4 changes: 1 addition & 3 deletions config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,4 @@

var OAUTH_API_KEY = 'F3Nc7_WaGdPtIlVowgHxJcnkpUw';

var TC_ENDPOINT = 'https://glib-mock.herokuapp.com/',
TC_AUTH_USERNAME = 'mess',
TC_AUTH_PASSWORD = 'appirio123';
var TC_ENDPOINT = 'https://glib-mock.herokuapp.com/';
4 changes: 4 additions & 0 deletions lib/jquery.js

Large diffs are not rendered by default.

Loading

0 comments on commit ae485cb

Please sign in to comment.