Fix const constructors (firebase#213)

cloudwheels · Sep 25, 2019 · f6dc29c · f6dc29c
1 parent 83a2061
commit f6dc29c
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 27 deletions.
diff --git a/packages/firebase_auth/CHANGELOG.md b/packages/firebase_auth/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.14.0+6
+
+* Update example app with correct const constructors.
+
 ## 0.14.0+5
 
 * On iOS, `fetchSignInMethodsForEmail` now returns an empty list when the email

diff --git a/packages/firebase_auth/example/lib/register_page.dart b/packages/firebase_auth/example/lib/register_page.dart
@@ -32,7 +32,7 @@ class RegisterPageState extends State<RegisterPage> {
           children: <Widget>[
             TextFormField(
               controller: _emailController,
-              decoration: InputDecoration(labelText: 'Email'),
+              decoration: const InputDecoration(labelText: 'Email'),
               validator: (String value) {
                 if (value.isEmpty) {
                   return 'Please enter some text';
@@ -42,7 +42,7 @@ class RegisterPageState extends State<RegisterPage> {
             ),
             TextFormField(
               controller: _passwordController,
-              decoration: InputDecoration(labelText: 'Password'),
+              decoration: const InputDecoration(labelText: 'Password'),
               validator: (String value) {
                 if (value.isEmpty) {
                   return 'Please enter some text';

diff --git a/packages/firebase_auth/example/lib/signin_page.dart b/packages/firebase_auth/example/lib/signin_page.dart
@@ -31,8 +31,8 @@ class SignInPageState extends State<SignInPage> {
               onPressed: () async {
                 final FirebaseUser user = await _auth.currentUser();
                 if (user == null) {
-                  Scaffold.of(context).showSnackBar(SnackBar(
-                    content: const Text('No one has signed in.'),
+                  Scaffold.of(context).showSnackBar(const SnackBar(
+                    content: Text('No one has signed in.'),
                   ));
                   return;
                 }
@@ -93,7 +93,7 @@ class _EmailPasswordFormState extends State<_EmailPasswordForm> {
           ),
           TextFormField(
             controller: _emailController,
-            decoration: InputDecoration(labelText: 'Email'),
+            decoration: const InputDecoration(labelText: 'Email'),
             validator: (String value) {
               if (value.isEmpty) {
                 return 'Please enter some text';
@@ -103,7 +103,7 @@ class _EmailPasswordFormState extends State<_EmailPasswordForm> {
           ),
           TextFormField(
             controller: _passwordController,
-            decoration: InputDecoration(labelText: 'Password'),
+            decoration: const InputDecoration(labelText: 'Password'),
             validator: (String value) {
               if (value.isEmpty) {
                 return 'Please enter some text';
@@ -238,7 +238,7 @@ class _EmailLinkSignInSectionState extends State<_EmailLinkSignInSection>
           ),
           TextFormField(
             controller: _emailController,
-            decoration: InputDecoration(labelText: 'Email'),
+            decoration: const InputDecoration(labelText: 'Email'),
             validator: (String value) {
               if (value.isEmpty) {
                 return 'Please enter your email.';
@@ -466,8 +466,8 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {
         ),
         TextFormField(
           controller: _phoneNumberController,
-          decoration:
-              InputDecoration(labelText: 'Phone number (+x xxx-xxx-xxxx)'),
+          decoration: const InputDecoration(
+              labelText: 'Phone number (+x xxx-xxx-xxxx)'),
           validator: (String value) {
             if (value.isEmpty) {
               return 'Phone number (+x xxx-xxx-xxxx)';
@@ -487,7 +487,7 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {
         ),
         TextField(
           controller: _smsController,
-          decoration: InputDecoration(labelText: 'Verification code'),
+          decoration: const InputDecoration(labelText: 'Verification code'),
         ),
         Container(
           padding: const EdgeInsets.symmetric(vertical: 16.0),
@@ -534,9 +534,8 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {
 
     final PhoneCodeSent codeSent =
         (String verificationId, [int forceResendingToken]) async {
-      widget._scaffold.showSnackBar(SnackBar(
-        content:
-            const Text('Please check your phone for the verification code.'),
+      widget._scaffold.showSnackBar(const SnackBar(
+        content: Text('Please check your phone for the verification code.'),
       ));
       _verificationId = verificationId;
     };
@@ -613,7 +612,7 @@ class _OtherProvidersSignInSectionState
                 groupValue: _selection,
                 onChanged: _handleRadioButtonSelected,
               ),
-              Text(
+              const Text(
                 'Github',
                 style: TextStyle(fontSize: 16.0),
               ),
@@ -622,7 +621,7 @@ class _OtherProvidersSignInSectionState
                 groupValue: _selection,
                 onChanged: _handleRadioButtonSelected,
               ),
-              Text(
+              const Text(
                 'Facebook',
                 style: TextStyle(
                   fontSize: 16.0,
@@ -633,7 +632,7 @@ class _OtherProvidersSignInSectionState
                 groupValue: _selection,
                 onChanged: _handleRadioButtonSelected,
               ),
-              Text(
+              const Text(
                 'Twitter',
                 style: TextStyle(fontSize: 16.0),
               ),
@@ -642,13 +641,14 @@ class _OtherProvidersSignInSectionState
         ),
         TextField(
           controller: _tokenController,
-          decoration: InputDecoration(labelText: 'Enter provider\'s token'),
+          decoration:
+              const InputDecoration(labelText: 'Enter provider\'s token'),
         ),
         Container(
           child: _showAuthSecretTextField
               ? TextField(
                   controller: _tokenSecretController,
-                  decoration: InputDecoration(
+                  decoration: const InputDecoration(
                       labelText: 'Enter provider\'s authTokenSecret'),
                 )
               : null,

diff --git a/packages/firebase_auth/pubspec.yaml b/packages/firebase_auth/pubspec.yaml
@@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS
   like Google, Facebook and Twitter.
 author: Flutter Team <[email protected]>
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_auth
-version: 0.14.0+5
+version: 0.14.0+6
 
 flutter:
   plugin:

diff --git a/packages/firebase_in_app_messaging/CHANGELOG.md b/packages/firebase_in_app_messaging/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.0.1+4
+
+* Update example app with correct const constructors.
+
 ## 0.0.1+3
 
 * Update AGP, gradle and inappmessaging-display versions on Android.

diff --git a/packages/firebase_in_app_messaging/example/lib/main.dart b/packages/firebase_in_app_messaging/example/lib/main.dart
@@ -48,7 +48,7 @@ class ProgrammaticTriggersExample extends StatelessWidget {
         padding: const EdgeInsets.all(24.0),
         child: Column(
           children: <Widget>[
-            Text(
+            const Text(
               "Programmatic Trigger",
               style: TextStyle(
                 fontStyle: FontStyle.italic,
@@ -61,8 +61,8 @@ class ProgrammaticTriggersExample extends StatelessWidget {
             RaisedButton(
               onPressed: () {
                 fiam.triggerEvent('chicken_event');
-                Scaffold.of(context).showSnackBar(SnackBar(
-                    content: const Text("Triggering event: chicken_event")));
+                Scaffold.of(context).showSnackBar(const SnackBar(
+                    content: Text("Triggering event: chicken_event")));
               },
               color: Colors.blue,
               child: Text(
@@ -92,7 +92,7 @@ class AnalyticsEventExample extends StatelessWidget {
         padding: const EdgeInsets.all(24.0),
         child: Column(
           children: <Widget>[
-            Text(
+            const Text(
               "Log an analytics event",
               style: TextStyle(
                 fontStyle: FontStyle.italic,
@@ -105,9 +105,8 @@ class AnalyticsEventExample extends StatelessWidget {
             RaisedButton(
               onPressed: () {
                 _sendAnalyticsEvent();
-                Scaffold.of(context).showSnackBar(SnackBar(
-                    content:
-                        const Text("Firing analytics event: awesome_event")));
+                Scaffold.of(context).showSnackBar(const SnackBar(
+                    content: Text("Firing analytics event: awesome_event")));
               },
               color: Colors.blue,
               child: Text(

diff --git a/packages/firebase_in_app_messaging/pubspec.yaml b/packages/firebase_in_app_messaging/pubspec.yaml
@@ -1,6 +1,6 @@
 name: firebase_in_app_messaging
 description: Flutter plugin for Firebase In-App Messaging.
-version: 0.0.1+3
+version: 0.0.1+4
 author: Flutter Team <[email protected]>
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_in_app_messaging