Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set LayoutParams in ReactTextView to fix crash
Summary: ReactTextView occasionally crashes when `setText` is called. Doing some cursory research, it looks like this could be a bug in Android. We also suspect it might be related to removeClippedSubviews though. The LayoutParams don't actually matter because RN controls layout, but on occasion (haven't narrowed down what this is...) `mLayout` is non-null and triggers relayout during `setText`, which fails because the LayoutParams are null. jesseruder came up with this fix and it appears to be working well. Stack trace: http://pastebin.com/P8VbxvPz Closes facebook#7011 Differential Revision: D3508097 fbshipit-source-id: 12b4aa11e42112c8ba19a1af325e3ee9a232d08f
- Loading branch information