Minimize included defs by adding a level of indirection

Reviewed By: zertosh Differential Revision: D7851714 fbshipit-source-id: aa14e003a612173c6f316cb76a26f7e78e7f15d4
clows · May 3, 2018 · be379ef · be379ef
1 parent 56d48bd
commit be379ef
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/ReactCommon/fabric/uimanager/BUCK b/ReactCommon/fabric/uimanager/BUCK
@@ -1,5 +1,5 @@
 load("//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
-load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "get_apple_inspector_flags")
+load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "get_apple_inspector_flags", "ANDROID", "APPLE")
 
 APPLE_COMPILER_FLAGS = []
 
@@ -57,9 +57,8 @@ rn_xplat_cxx_library(
 )
 
 if not IS_OSS_BUILD:
-    load("@xplat//configurations/buck:default_platform_defs.bzl", "APPLE")
-
-    cxx_test(
+    load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test")
+    fb_xplat_cxx_test(
         name = "tests",
         srcs = glob(["tests/**/*.cpp"]),
         headers = glob(["tests/**/*.h"]),

diff --git a/ReactCommon/fabric/view/BUCK b/ReactCommon/fabric/view/BUCK
@@ -1,6 +1,5 @@
 load("//configurations/buck/apple:flag_defs.bzl", "get_application_ios_flags", "get_debug_preprocessor_flags", "OBJC_ARC_PREPROCESSOR_FLAGS")
-load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "rn_xplat_cxx_library", "get_apple_inspector_flags")
-load("//ReactNative:DEFS.bzl", "react_native_xplat_target")
+load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "rn_xplat_cxx_library", "get_apple_inspector_flags", "react_native_xplat_target", "ANDROID", "APPLE")
 
 APPLE_COMPILER_FLAGS = []
 
@@ -61,9 +60,8 @@ rn_xplat_cxx_library(
 )
 
 if not IS_OSS_BUILD:
-    load("@xplat//configurations/buck:default_platform_defs.bzl", "APPLE")
-
-    cxx_test(
+    load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test")
+    fb_xplat_cxx_test(
         name = "tests",
         srcs = glob(["tests/**/*.cpp"]),
         headers = glob(["tests/**/*.h"]),