Skip to content

Commit

Permalink
batman-adv: Rename batadv_nc_path *_free_ref function to *_put
Browse files Browse the repository at this point in the history
The batman-adv source code is the only place in the kernel which uses the
*_free_ref naming scheme for the *_put functions. Changing it to *_put
makes it more consistent and makes it easier to understand the connection
to the *_get functions.

Signed-off-by: Sven Eckelmann <[email protected]>
Signed-off-by: Marek Lindner <[email protected]>
Signed-off-by: Antonio Quartulli <[email protected]>
  • Loading branch information
ecsv authored and ordex committed Feb 23, 2016
1 parent 27ad754 commit 5fff282
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions net/batman-adv/network-coding.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,11 +247,11 @@ static void batadv_nc_path_release(struct kref *ref)
}

/**
* batadv_nc_path_free_ref - decrement the nc_path refcounter and possibly
* batadv_nc_path_put - decrement the nc_path refcounter and possibly
* release it
* @nc_path: nc_path to be free'd
*/
static void batadv_nc_path_free_ref(struct batadv_nc_path *nc_path)
static void batadv_nc_path_put(struct batadv_nc_path *nc_path)
{
kref_put(&nc_path->refcount, batadv_nc_path_release);
}
Expand All @@ -263,7 +263,7 @@ static void batadv_nc_path_free_ref(struct batadv_nc_path *nc_path)
static void batadv_nc_packet_free(struct batadv_nc_packet *nc_packet)
{
kfree_skb(nc_packet->skb);
batadv_nc_path_free_ref(nc_packet->nc_path);
batadv_nc_path_put(nc_packet->nc_path);
kfree(nc_packet);
}

Expand Down Expand Up @@ -467,7 +467,7 @@ static void batadv_nc_purge_paths(struct batadv_priv *bat_priv,
"Remove nc_path %pM -> %pM\n",
nc_path->prev_hop, nc_path->next_hop);
hlist_del_rcu(&nc_path->hash_entry);
batadv_nc_path_free_ref(nc_path);
batadv_nc_path_put(nc_path);
}
spin_unlock_bh(lock);
}
Expand Down Expand Up @@ -1555,7 +1555,7 @@ bool batadv_nc_skb_forward(struct sk_buff *skb,
return true;

free_nc_path:
batadv_nc_path_free_ref(nc_path);
batadv_nc_path_put(nc_path);
out:
/* Packet is not consumed */
return false;
Expand Down Expand Up @@ -1617,7 +1617,7 @@ void batadv_nc_skb_store_for_decoding(struct batadv_priv *bat_priv,
free_skb:
kfree_skb(skb);
free_nc_path:
batadv_nc_path_free_ref(nc_path);
batadv_nc_path_put(nc_path);
out:
return;
}
Expand Down

0 comments on commit 5fff282

Please sign in to comment.