Skip to content

Commit

Permalink
xfs: remove redundant stat assignment in xfs_bulkstat_one_int
Browse files Browse the repository at this point in the history
From: Jie Liu <[email protected]>

Remove the redundant BULKSTAT_RV_NOTHING assignment in case of call
xfs_iget() failed at xfs_bulkstat_one_int().

Signed-off-by: Jie Liu <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Signed-off-by: Dave Chinner <[email protected]>
  • Loading branch information
pibroch authored and dchinner committed Jul 24, 2014
1 parent 2451337 commit 8fe6577
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fs/xfs/xfs_itable.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,8 @@ xfs_bulkstat_one_int(
error = xfs_iget(mp, NULL, ino,
(XFS_IGET_DONTCACHE | XFS_IGET_UNTRUSTED),
XFS_ILOCK_SHARED, &ip);
if (error) {
*stat = BULKSTAT_RV_NOTHING;
if (error)
goto out_free;
}

ASSERT(ip != NULL);
ASSERT(ip->i_imap.im_blkno != 0);
Expand Down Expand Up @@ -136,7 +134,6 @@ xfs_bulkstat_one_int(
IRELE(ip);

error = formatter(buffer, ubsize, ubused, buf);

if (!error)
*stat = BULKSTAT_RV_DIDONE;

Expand Down

0 comments on commit 8fe6577

Please sign in to comment.