Skip to content

Commit

Permalink
drivers/perf: arm_pmu: make info messages more verbose
Browse files Browse the repository at this point in the history
On a big.LITTLE system e.g. with Cortex A57 and A53 in case not all cores
are online at PMU probe time we might get

hw perfevents: failed to probe PMU!
hw perfevents: failed to register PMU devices!

making it unclear which cores failed, here.

Add the device tree full name which failed and the error value resulting
in a more verbose and helpful message like

hw perfevents: /soc/pmu_a53: failed to probe PMU! Error -6
hw perfevents: /soc/pmu_a53: failed to register PMU devices! Error -6

Signed-off-by: Dirk Behme <[email protected]>
Signed-off-by: Will Deacon <[email protected]>
  • Loading branch information
dirkbehme authored and wildea01 committed Feb 9, 2016
1 parent 8d1a0ae commit c6b9065
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/perf/arm_pmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,8 @@ int arm_pmu_device_probe(struct platform_device *pdev,
}

if (ret) {
pr_info("failed to probe PMU!\n");
pr_info("%s: failed to probe PMU! Error %i\n",
node->full_name, ret);
goto out_free;
}

Expand All @@ -927,7 +928,8 @@ int arm_pmu_device_probe(struct platform_device *pdev,
out_destroy:
cpu_pmu_destroy(pmu);
out_free:
pr_info("failed to register PMU devices!\n");
pr_info("%s: failed to register PMU devices! Error %i\n",
node->full_name, ret);
kfree(pmu);
return ret;
}

0 comments on commit c6b9065

Please sign in to comment.