Fix workflows

cmalf · Mar 19, 2021 · 8b7a360 · 8b7a360
1 parent 4023da6
commit 8b7a360
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 22 deletions.
diff --git a/.github/workflows/2-bump-versions.yml b/.github/workflows/2-bump-versions.yml
@@ -9,6 +9,11 @@ jobs:
     steps:
       - name: Checkout source code
         uses: actions/checkout@v2
+        with:
+          # NOTE @v2 uses the token as an auth http header. Set it to
+          # a Personal Access Token instead of secrets.GITHUB_TOKEN
+          # so that tag pushes trigger repo push events.
+          token: ${{ secrets.MY_GITHUB_ACCESS_TOKEN }}
       - name: Bump Version (Patch)
         if:
           github.repository == 'chrisleekr/binance-trading-bot' && github.ref ==

diff --git a/.github/workflows/3-release.yml b/.github/workflows/3-release.yml
@@ -2,9 +2,8 @@ name: 3. Release
 
 on:
   push:
-    # Sequence of patterns matched against refs/tags
     tags:
-      - 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10
+      - 'v*'
 
 jobs:
   create-release:
@@ -25,7 +24,7 @@ jobs:
           prerelease: false
       - name: Build/Push production docker image
         run: |
-          echo ${{ secrets.DOCKER_PASSWORD }} | docker login -u ${{ secrets.DOCKER_USERNAME }} --password-stdin ${{ secrets.REGISTRY_DOMAIN }}
+          echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_USERNAME }}" --password-stdin ${{ secrets.REGISTRY_DOMAIN }}
           PACKAGE_VERSION=$(grep version package.json | cut -c 15- | rev | cut -c 3- | rev)
           docker build . --build-arg PACKAGE_VERSION=$PACKAGE_VERSION --build-arg NODE_ENV=production --target production-stage -t ${{ secrets.REGISTRY_DOMAIN }}/chrisleekr/binance-trading-bot:latest -t ${{ secrets.REGISTRY_DOMAIN }}/chrisleekr/binance-trading-bot:$PACKAGE_VERSION
           docker push ${{ secrets.REGISTRY_DOMAIN }}/chrisleekr/binance-trading-bot:$PACKAGE_VERSION

diff --git a/README.md b/README.md
@@ -319,22 +319,3 @@ Or use the frontend to adjust configurations after launching the application.
 - [@OOtta](https://github.com/OOtta)
 
 ## Contributors
-
-<table>
-<tr>
-    <td align="center" style="word-wrap: break-word; width: 150.0; height: 150.0">
-        <a href=https://github.com/chrisleekr>
-            <img src=https://avatars.githubusercontent.com/u/5715919?v=4 width="100;"  style="border-radius:50%;align-items:center;justify-content:center;overflow:hidden;padding-top:10px" alt=chrisleekr/>
-            <br />
-            <sub style="font-size:14px"><b>chrisleekr</b></sub>
-        </a>
-    </td>
-    <td align="center" style="word-wrap: break-word; width: 150.0; height: 150.0">
-        <a href=https://github.com/thamlth>
-            <img src=https://avatars.githubusercontent.com/u/45093611?v=4 width="100;"  style="border-radius:50%;align-items:center;justify-content:center;overflow:hidden;padding-top:10px" alt=thamlth/>
-            <br />
-            <sub style="font-size:14px"><b>thamlth</b></sub>
-        </a>
-    </td>
-</tr>
-</table>