Skip to content

Commit

Permalink
Remove "--fresh" option from installer
Browse files Browse the repository at this point in the history
Turns out that this doesn't really work at all. `brew install` _never_
reuses options in the first place, and using this option with `brew
upgrade` results in some nasty corner cases in passing options to
dependencies.
  • Loading branch information
jacknagel committed Mar 9, 2014
1 parent 3c9a197 commit 8cdf4d8
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 10 deletions.
5 changes: 1 addition & 4 deletions Library/Contributions/manpages/brew.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ Note that these flags should only appear after a command.
Print a JSON representation of <formula>. Currently the only accepted value
for <version> is `v1`.

* `install [--debug] [--env=<std|super>] [--ignore-dependencies] [--only-dependencies] [--fresh] [--cc=<compiler>] [--build-from-source] [--devel|--HEAD]` <formula>:
* `install [--debug] [--env=<std|super>] [--ignore-dependencies] [--only-dependencies] [--cc=<compiler>] [--build-from-source] [--devel|--HEAD]` <formula>:
Install <formula>.

<formula> is usually the name of the formula to install, but it can be specified
Expand All @@ -175,9 +175,6 @@ Note that these flags should only appear after a command.
If `--only-dependencies` is passed, install the dependencies with specified
options but do not install the specified formula.

If `--fresh` is passed, the installation process will not re-use any
options from previous installs.

If `--cc=<compiler>` is passed, attempt to compile using <compiler>.
<compiler> should be the name of the compiler's executable, for instance
`gcc-4.2` for Apple's GCC 4.2, or `gcc-4.8` for a Homebrew-provided GCC
Expand Down
1 change: 0 additions & 1 deletion Library/Homebrew/extend/ARGV.rb
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ def filter_for_dependencies
--build-bottle
--debug -d
--devel
--fresh
--interactive -i
--HEAD
]
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/formula_installer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ def sanitized_ARGV_options

def build_argv
opts = Options.coerce(sanitized_ARGV_options)
opts.concat(options) unless opts.include? "--fresh"
opts.concat(options)
opts << Option.new("--build-from-source") # don't download bottle
end

Expand Down
5 changes: 1 addition & 4 deletions share/man/man1/brew.1
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ To view formula history locally: \fBbrew log \-p <formula>\fR\.
Print a JSON representation of \fIformula\fR\. Currently the only accepted value for \fIversion\fR is \fBv1\fR\.
.
.TP
\fBinstall [\-\-debug] [\-\-env=<std|super>] [\-\-ignore\-dependencies] [\-\-only\-dependencies] [\-\-fresh] [\-\-cc=<compiler>] [\-\-build\-from\-source] [\-\-devel|\-\-HEAD]\fR \fIformula\fR
\fBinstall [\-\-debug] [\-\-env=<std|super>] [\-\-ignore\-dependencies] [\-\-only\-dependencies] [\-\-cc=<compiler>] [\-\-build\-from\-source] [\-\-devel|\-\-HEAD]\fR \fIformula\fR
Install \fIformula\fR\.
.
.IP
Expand All @@ -196,9 +196,6 @@ If \fB\-\-ignore\-dependencies\fR is passed, skip installing any dependencies of
If \fB\-\-only\-dependencies\fR is passed, install the dependencies with specified options but do not install the specified formula\.
.
.IP
If \fB\-\-fresh\fR is passed, the installation process will not re\-use any options from previous installs\.
.
.IP
If \fB\-\-cc=<compiler>\fR is passed, attempt to compile using \fIcompiler\fR\. \fIcompiler\fR should be the name of the compiler\'s executable, for instance \fBgcc\-4\.2\fR for Apple\'s GCC 4\.2, or \fBgcc\-4\.8\fR for a Homebrew\-provided GCC 4\.8\.
.
.IP
Expand Down

0 comments on commit 8cdf4d8

Please sign in to comment.