[registry-facade] Force retry on timeout (gitpod-io#19649)

components/registry-facade/pkg/registry/http_client.go

@@ -5,13 +5,24 @@
 package registry
 
 import (
+	"context"
 	"net/http"
 
 	"github.com/gitpod-io/gitpod/common-go/log"
 	"github.com/hashicorp/go-retryablehttp"
 	"github.com/sirupsen/logrus"
 )
 
+// Temporaryable is to match an error that has `.Temporary()`
+type Temporaryable interface {
+	Temporary() bool
+}
+
+// Timeoutable is to match an error that has `.Timeout()`
+type Timeoutable interface {
+	Timeout() bool
+}
+
 type Option func(opts *httpOpts)
 
 func NewRetryableHTTPClient(options ...Option) *http.Client {
@@ -30,6 +41,18 @@ func NewRetryableHTTPClient(options ...Option) *http.Client {
 		client.HTTPClient = opts.HTTPClient
 	}
 
+	client.CheckRetry = func(ctx context.Context, resp *http.Response, err error) (bool, error) {
+		if terr, ok := err.(Temporaryable); ok && terr.Temporary() {
+			return true, nil
+		}
+
+		if terr, ok := err.(Timeoutable); ok && terr.Timeout() {
+			return true, nil
+		}
+
+		return retryablehttp.DefaultRetryPolicy(ctx, resp, err)
+	}
+
 	return client.StandardClient()
 }