Ensure the pending queue is purged after error

cmdkoh · Sep 24, 2016 · 56a13a9 · 56a13a9
1 parent 15f00dd
commit 56a13a9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -29,7 +29,9 @@ module.exports = function (dependencies) {
     this.endpointManager.on("error", (err) => {
       this.queue.forEach((resolve) => {
         resolve(Promise.reject(err));
-      })
+      });
+
+      this.queue = [];
     });
 
     this.queue = [];

diff --git a/test/client.js b/test/client.js
@@ -472,10 +472,10 @@ describe("Client", function () {
       });
 
       context("connection fails", function () {
-        let promises;
+        let promises, client;
 
         beforeEach( function() {
-          const client = new Client( { address: "testapi" } );
+          client = new Client( { address: "testapi" } );
 
           fakes.endpointManager.getStream.onCall(0).returns(fakes.streams[0]);
 
@@ -504,7 +504,13 @@ describe("Client", function () {
             expect(response[1]).to.deep.equal({ device: "adfe5969", error: new Error("endpoint failed") });
             expect(response[2]).to.deep.equal({ device: "abcd1335", error: new Error("endpoint failed") });
           })
-        })
+        });
+
+        it("clears the queue", function () {
+          return promises.then( () => {
+            expect(client.queue.length).to.equal(0);
+          });
+        });
       });
 
     });