Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo all icons to be square #16

Closed
dankohn opened this issue Nov 17, 2017 · 7 comments
Closed

Redo all icons to be square #16

dankohn opened this issue Nov 17, 2017 · 7 comments
Assignees

Comments

@dankohn
Copy link
Contributor

dankohn commented Nov 17, 2017

This will make them more usable in a variety of contexts.

Cc @radoslaw @lukaszgryglicki

@radoslaw
Copy link

Please note that for instance,
the opentracing .ai icon has the same issue as its .svg counterpart
and
the .png version is not square, if it matters

I guess other projects' icons may have similar issues. This is in the "color" folder and the "black,white" folders may be affected too.

Also, I suspect someone was fixing the position of those icons. While it may have helped some, it moved others unnecessarily. I suggest changing the -1 for position-top to 0 as seen here:
screen shot 2017-11-17 at 16 25 25

@dankohn
Copy link
Contributor Author

dankohn commented Nov 17, 2017

@radoslaw The last issue is unique to how @lukaszgryglicki is using them. I'm expecting @alexcontini to redo the color, black and white versions of all icons in all formats, which should put us on firm ground going forward.

@lukaszgryglicki
Copy link
Member

Actually, I have no control over how those icons are used.
This is Grafana code.
I only have a "rebranding" script that replaces Grafana icon with our icon.
This cannot be done via any config option, I've even opened a feature request on Grafana repos (some time ago), but They closed it and said they "rebranding is not something we want to support".

@dankohn
Copy link
Contributor Author

dankohn commented Nov 17, 2017 via email

@dankohn
Copy link
Contributor Author

dankohn commented Dec 15, 2017

@radoslaw Could you please confirm that the icons are square so we can close this issue.

@radoslaw
Copy link

The icons are now square.

@dankohn
Copy link
Contributor Author

dankohn commented Dec 16, 2017

Closing, thanks.

@dankohn dankohn closed this as completed Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants