Skip to content

Commit

Permalink
Use ARG instead of ENV
Browse files Browse the repository at this point in the history
No need to persist this into runtime environment. Also, this way you can
customize the build/runtime dependencies on the docker command line.
  • Loading branch information
coldfix committed Jun 5, 2017
1 parent 2eef45b commit 4b65bde
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ FROM alpine:edge
COPY . /goaccess
WORKDIR /goaccess

ENV build_deps="build-base ncurses-dev autoconf automake git gettext-dev"
ARG build_deps="build-base ncurses-dev autoconf automake git gettext-dev"
ARG runtime_deps="tini ncurses libintl gettext "

RUN apk update && \
apk add -u tini ncurses libintl gettext $build_deps && \
apk add -u $runtime_deps $build_deps && \
autoreconf -fiv && \
./configure --enable-utf8 && \
make && \
Expand Down

0 comments on commit 4b65bde

Please sign in to comment.