Remove -Wno-sign-compare, -Wno-unused-variable and -Wno-format.

Bug: webrtc:9251 Change-Id: Ide719100cb99fdf5fe6700af9d5f4a1884ac2b67 Reviewed-on: https://webrtc-review.googlesource.com/87842 Reviewed-by: Kári Helgason <[email protected]> Commit-Queue: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/master@{#23905}
cneyoo · Jul 10, 2018 · 3e603ec · 3e603ec
1 parent 1a4746a
commit 3e603ec
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 15 deletions.
diff --git a/examples/BUILD.gn b/examples/BUILD.gn
@@ -224,14 +224,6 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
 
   config("apprtc_signaling_config") {
     include_dirs = [ "objc/AppRTCMobile" ]
-
-    # GN orders flags on a target before flags from configs. The default config
-    # adds these flags so to cancel them out they need to come from a config and
-    # cannot be on the target directly.
-    cflags = [
-      "-Wno-sign-compare",
-      "-Wno-unused-variable",
-    ]
   }
 
   rtc_static_library("apprtc_signaling") {
@@ -681,14 +673,9 @@ if (is_linux || is_win) {
     cflags = []
     if (is_win && is_clang) {
       cflags += [
-        # Disable warnings failing when compiling with Clang on Windows.
-        # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
-        "-Wno-format",
-
         # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6271
         # for -Wno-reorder and -Wno-sign-compare
         "-Wno-reorder",
-        "-Wno-sign-compare",
       ]
     }
     if (is_linux && target_cpu == "x86") {

diff --git a/examples/objc/AppRTCMobile/ARDAppClient.m b/examples/objc/AppRTCMobile/ARDAppClient.m
@@ -54,10 +54,12 @@
 static NSString * const kARDVideoTrackKind = @"video";
 
 // TODO(tkchin): Add these as UI options.
+#if defined(WEBRTC_IOS)
 static BOOL const kARDAppClientEnableTracing = NO;
 static BOOL const kARDAppClientEnableRtcEventLog = YES;
 static int64_t const kARDAppClientAecDumpMaxSizeInBytes = 5e6;  // 5 MB.
 static int64_t const kARDAppClientRtcEventLogMaxSizeInBytes = 5e6;  // 5 MB.
+#endif
 static int const kKbpsMultiplier = 1000;
 
 // We need a proxy to NSTimer because it causes a strong retain cycle. When

diff --git a/examples/objc/AppRTCMobile/ARDAppEngineClient.m b/examples/objc/AppRTCMobile/ARDAppEngineClient.m
@@ -55,7 +55,6 @@ - (void)joinRoomWithRoomId:(NSString *)roomId
   RTCLog(@"Joining room:%@ on room server.", roomId);
   NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:roomURL];
   request.HTTPMethod = @"POST";
-  __weak ARDAppEngineClient *weakSelf = self;
   [NSURLConnection sendAsyncRequest:request
                   completionHandler:^(NSURLResponse *response, NSData *data, NSError *error) {
                     if (error) {
@@ -96,7 +95,6 @@ - (void)sendMessage:(ARDSignalingMessage *)message
   NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url];
   request.HTTPMethod = @"POST";
   request.HTTPBody = data;
-  __weak ARDAppEngineClient *weakSelf = self;
   [NSURLConnection sendAsyncRequest:request
                   completionHandler:^(NSURLResponse *response,
                                       NSData *data,