Use absl::optional instead or rtc::Optional

BUG: webrtc:9078 Change-Id: I69aedce324d86e8894b81210a2de17c5ef68fd11 Reviewed-on: https://webrtc-review.googlesource.com/77082 Commit-Queue: Danil Chapovalov <[email protected]> Reviewed-by: Karl Wiberg <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/master@{#23440}
cneyoo · May 30, 2018 · 7ba9e92 · 7ba9e92
1 parent 700fc84
commit 7ba9e92
Show file tree

Hide file tree

Showing 5 changed files with 49 additions and 490 deletions.
diff --git a/DEPS b/DEPS
@@ -734,4 +734,7 @@ include_rules = [
   "+rtc_base",
   "+test",
   "+rtc_tools",
+
+  # Abseil whitelist.
+  "+absl/types/optional.h",
 ]
diff --git a/api/BUILD.gn b/api/BUILD.gn
@@ -230,16 +230,15 @@ rtc_source_set("array_view") {
   ]
 }
 
+# TODO(bugs.webrtc.org/9078): Deprecated, replaced by absl/types:optional.
+# Delete after webrtc and downstreams users are updated.
 rtc_source_set("optional") {
   visibility = [ "*" ]
   sources = [
-    "optional.cc",
     "optional.h",
   ]
   deps = [
-    ":array_view",
-    "../rtc_base:checks",
-    "../rtc_base:sanitizer",
+    "//third_party/abseil-cpp/absl/types:optional",
   ]
 }
 
@@ -381,6 +380,9 @@ if (rtc_include_tests) {
 
     sources = [
       "array_view_unittest.cc",
+
+      # TODO(bugs.webrtc.org/8821): Remove optional_unittests when webrtc starts
+      # running absl unittest on each commit.
       "optional_unittest.cc",
       "ortc/mediadescription_unittest.cc",
       "ortc/sessiondescription_unittest.cc",

diff --git a/api/optional.cc b/api/optional.cc