[Temp] Better handle private events not working

devhubapp#140 https://twitter.com/devhub_app/status/1129499699931697152?s=20
cocoroise · May 26, 2019 · 099b844 · 099b844
1 parent 2228aa6
commit 099b844
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 3 deletions.
diff --git a/packages/components/src/components/cards/EventCards.tsx b/packages/components/src/components/cards/EventCards.tsx
@@ -19,6 +19,7 @@ import { FlatList, FlatListProps } from '../../libs/flatlist'
 import { Platform } from '../../libs/platform'
 import * as actions from '../../redux/actions'
 import { Button } from '../common/Button'
+import { ButtonLink } from '../common/ButtonLink'
 import { fabSize } from '../common/FAB'
 import { RefreshControl } from '../common/RefreshControl'
 import { Spacer } from '../common/Spacer'
@@ -29,6 +30,7 @@ import { useTheme } from '../context/ThemeContext'
 import { fabSpacing, shouldRenderFAB } from '../layout/FABRenderer'
 import { EmptyCards, EmptyCardsProps } from './EmptyCards'
 import { EventCard, EventCardProps } from './EventCard'
+import { GenericMessageWithButtonView } from './GenericMessageWithButtonView'
 import {
   CardItemSeparator,
   getCardItemSeparatorThemeColor,
@@ -313,6 +315,28 @@ export const EventCards = React.memo((props: EventCardsProps) => {
   }
 
   if (!(items && items.length)) {
+    if (errorMessage === 'Resource not accessible by integration') {
+      return (
+        <GenericMessageWithButtonView
+          buttonView={
+            !!refresh && (
+              <ButtonLink
+                analyticsLabel="open_private_issue"
+                children="Open GitHub Issue To Upvote"
+                disabled={loadState !== 'error'}
+                href="https://github.com/devhubapp/devhub/issues/140"
+                loading={loadState === 'loading'}
+              />
+            )
+          }
+          emoji="confused"
+          fullCenter
+          title="Private access temporarily disabled"
+          subtitle="GitHub has temporarily disabled private access for GitHub Apps on their API. Please upvote the issue below to show your interest on a fix."
+        />
+      )
+    }
+
     return (
       <EmptyCards
         clearedAt={column.filters && column.filters.clearedAt}

diff --git a/packages/components/src/components/cards/GenericMessageWithButtonView.tsx b/packages/components/src/components/cards/GenericMessageWithButtonView.tsx
@@ -11,20 +11,27 @@ import { ThemedText } from '../themed/ThemedText'
 export interface GenericMessageWithButtonViewProps {
   buttonView: React.ReactNode
   emoji: GitHubEmoji | null
+  fullCenter?: boolean
+  style?: ViewProps['style']
   subtitle: string | undefined | null
   title: string | undefined | null
-  style?: ViewProps['style']
 }
 
 export const GenericMessageWithButtonView = React.memo(
   (props: GenericMessageWithButtonViewProps) => {
-    const { buttonView, emoji, style, subtitle, title } = props
+    const { buttonView, emoji, fullCenter, style, subtitle, title } = props
 
     const emojiImageURL = emoji ? getEmojiImageURL(emoji) : null
 
     return (
       <View
         style={[
+          fullCenter && {
+            flex: 1,
+            alignContent: 'center',
+            alignItems: 'center',
+            justifyContent: 'center',
+          },
           {
             width: '100%',
             padding: contentPadding,

diff --git a/packages/components/src/components/modals/AddColumnModal.tsx b/packages/components/src/components/modals/AddColumnModal.tsx
@@ -175,7 +175,7 @@ const columnTypes: Array<{
             subtype: 'REPO_EVENTS',
           },
           paramList: ['owner', 'repo'],
-          isPrivateSupported: true,
+          isPrivateSupported: false, // https://github.com/devhubapp/devhub/issues/140
         },
       },
       {