Change rate limiter burst size to 1 (cadence-workflow#2246)

code-4-fun · Jul 22, 2019 · 8766b37 · 8766b37
1 parent e73fc9f
commit 8766b37
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/common/quotas/policy.go b/common/quotas/policy.go
@@ -63,7 +63,7 @@ func (d *MultiStageRateLimiter) Allow(info Info) bool {
 	if !ok {
 		// create a new limiter
 		initialRps := d.domainRPS()
-		domainLimiter := NewRateLimiter(&initialRps, _defaultRPSTTL, _burstMultiplier*int(d.domainRPS()))
+		domainLimiter := NewRateLimiter(&initialRps, _defaultRPSTTL, _burstSize)
 
 		// verify that it is needed and add to map
 		d.Lock()

diff --git a/common/quotas/ratelimiter.go b/common/quotas/ratelimiter.go
@@ -31,8 +31,8 @@ import (
 )
 
 const (
-	_defaultRPSTTL   = 60 * time.Second
-	_burstMultiplier = 2
+	_defaultRPSTTL = 60 * time.Second
+	_burstSize     = 1
 )
 
 // RateLimiter is a wrapper around the golang rate limiter handling dynamic
@@ -55,7 +55,7 @@ type RateLimiter struct {
 // limiter
 func NewSimpleRateLimiter(rps int) *RateLimiter {
 	initialRps := float64(rps)
-	return NewRateLimiter(&initialRps, _defaultRPSTTL, _burstMultiplier*rps)
+	return NewRateLimiter(&initialRps, _defaultRPSTTL, _burstSize)
 }
 
 // NewRateLimiter returns a new rate limiter that can handle dynamic
@@ -144,7 +144,7 @@ type DynamicRateLimiter struct {
 // NewDynamicRateLimiter returns a rate limiter which handles dynamic config
 func NewDynamicRateLimiter(rps RPSFunc) *DynamicRateLimiter {
 	initialRps := rps()
-	rl := NewRateLimiter(&initialRps, _defaultRPSTTL, _burstMultiplier*int(rps()))
+	rl := NewRateLimiter(&initialRps, _defaultRPSTTL, _burstSize)
 	return &DynamicRateLimiter{rps, rl}
 }