Impl: icons with support for light&dark themes #32
Conversation
- Start button is active even though it doesn't do anything when clicked when the workspace template has updates. - resolves #31
- to `Update and start` to reflect that the it also starts the workspace - more consistent with the web client
- LAF support in Toolbox is quite primitive, it turns out icon support for light and dark themes is enabled by a masked flag on the icons - the mask flag controls whether the svg colors are inverted in light&dark themes.
| @@ -78,7 +78,7 @@ class CoderRemoteEnvironment( | |||
| workspace = workspace.copy(latestBuild = build) | |||
| update(workspace, agent) | |||
| }, | |||
| Action(context.i18n.ptrl("Update"), enabled = { workspace.outdated }) { | |||
| Action(context.i18n.ptrl("Update and start"), enabled = { workspace.outdated }) { | |||
There was a problem hiding this comment.
We use "Update and restart" on the web dashboard if the workspace is already in a Running state.
And "Update and start" if the workspace is Stopped
So, we need to handle both cases separately.
Also, instead of disabling, can we just hide the unavailable actions?
There was a problem hiding this comment.
Sure I think we can do both though I'm not sure how do I get to have a running workspace but outdated so that I can test and play with it.
In the meantime let me write two issues to capture the requests.
There was a problem hiding this comment.
Update: unavailable actions are now hidden:
There was a problem hiding this comment.
I'm not sure how do I get to have a running workspace but outdated so that I can test and play with it.
I can help provide one. If you are an admin, you can switch your workspace to a previous template version, and that makes it "Update and restart"
There was a problem hiding this comment.
I'm not an admin, that would indeed simplify my testing.
Among other things we also fixed and issue with the
Startbutton which remained active when a workspace was stopped and outdated. In order to be more consistent with the web client we renamed the button toUpdate and startto reflect that it also starts the workspace.Running and outdated workspaces also received a new action button:
Update and restart.