Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl: improve publish task #49

Merged
merged 2 commits into from
Mar 27, 2025
Merged

impl: improve publish task #49

merged 2 commits into from
Mar 27, 2025

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Mar 27, 2025

  • marketplace token should be in JETBRAINS_MARKETPLACE_PUBLISH_TOKEN env. variable
  • calls the proper api for upload based on whether it's the first release version or not

@fioan89
impl: improve publish task
b1fd0f8 
- marketplace token should be in JETBRAINS_MARKETPLACE_PUBLISH_TOKEN env. variable
- calls the proper api for upload based on whether it's the first release version or not
@fioan89 fioan89 requested review from matifali and bcpeinhardt March 27, 2025 22:23
matifali
matifali approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may have to push a tagged release.

@fioan89
impl: zip task like in the sample plugin
8ed38ab 
- the existing pluginZip implementation which is now renamed to pluginPrettyZip is producing
  an artifact suited for manual local deployment. The structure differ from the sample in the
  following ways:
  - zip name is: coder-toolbox-0.1.0.zip instead of com.coder.toolbox-0.1.0.zip
  - the zip contains a root folder named com.coder.toolbox that can be easily deployed in Toolbox plugin location
- with this patch, pluginZip is copying what the Toolbox sample does.
@fioan89 fioan89 marked this pull request as ready for review March 27, 2025 22:59
@fioan89 fioan89 merged commit ca6f8a3 into main Mar 27, 2025
5 checks passed
@fioan89 fioan89 deleted the improve-publish-task branch March 27, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

@bcpeinhardt bcpeinhardt Awaiting requested review from bcpeinhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fioan89 @matifali