Impl: update ssh config when settings change #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- they did not reflect any subsequent update because updates create a new backing readonly instance - with this patch we simplified the code even more by exposing a readonly interface with all of the implementation in the CoderSettingsStore. PluginSettingsStore and Environments are the only persist-able stores. - because read only instances share the same settings store instances any update on the writable will reflect on the readable instances as well.
…ings - right now the ssh config is triggered only when at the login and only when new workspaces are created. In the last case, the ssh config updates only the new sections. - but the user can go into settings page and enable or disable the wildcard ssh config. With this patch after the user hits Save, the ssh re-configuration is triggered, without the need to restart Toolbox.
matifali
approved these changes
Mar 29, 2025
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (9)
- src/main/kotlin/com/coder/toolbox/CoderRemoteEnvironment.kt: Language not supported
- src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt: Language not supported
- src/main/kotlin/com/coder/toolbox/cli/CoderCLIManager.kt: Language not supported
- src/main/kotlin/com/coder/toolbox/settings/CoderSettings.kt: Language not supported
- src/main/kotlin/com/coder/toolbox/settings/ReadOnlyCoderSettings.kt: Language not supported
- src/main/kotlin/com/coder/toolbox/store/CoderSettingsStore.kt: Language not supported
- src/main/kotlin/com/coder/toolbox/util/TLS.kt: Language not supported
- src/main/kotlin/com/coder/toolbox/views/CoderSettingsPage.kt: Language not supported
- src/main/kotlin/com/coder/toolbox/views/EnvironmentView.kt: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created. In the last case, the ssh config updates only the new sections.
after the user hits Save, the ssh re-configuration is triggered, without the need to restart Toolbox.
Also a major fix - read only settings acted as snapshots in the sense that they did not reflect any subsequent update to the underlying store because updates create a new readonly instance
implementation in the CoderSettingsStore. PluginSettingsStore and Environments are the only persist-able
stores.
on the readable instances as well.