feat: add app status tracking to the backend #17163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Mar 28, 2025
| defer q.mutex.Unlock() | ||
|
|
||
| status := database.WorkspaceAppStatus{ | ||
| ID: arg.ID, |
There was a problem hiding this comment.
Given that we generate the UUID in the database, we should avoid inserting UUIDs.
Comment on lines
+47
to
+49
| INSERT INTO workspace_app_statuses (id, created_at, workspace_id, agent_id, app_id, state, message, needs_user_attention, uri, icon) | ||
| VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10) | ||
| RETURNING *; |
There was a problem hiding this comment.
Suggestion: drop the ID here in the inputs and just return the auto-generated value from the DB.
Comment on lines
+347
to
+348
| client, db := coderdtest.NewWithDatabase(t, nil) | ||
| user := coderdtest.CreateFirstUser(t, client) |
There was a problem hiding this comment.
Testing with the owner can mask authz issues.
Instead, create another member user/client and then test with that client.
johnstcn
approved these changes
Mar 31, 2025
|
/cherry-pick release/2.21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does ~95% of the backend work required to integrate the AI work.
Most left to integrate from the tasks branch is just frontend, which will be a lot smaller I believe.
The real difference between this branch and that one is the abstraction -- this now attaches statuses to apps, and returns the latest status reported as part of a workspace.
This change enables us to have a similar UX to in the tasks branch, but for agents other than Claude Code as well. Any app can report status now.