Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support windsurf setups for coder extension #441

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Conversation

amberry
Copy link
Contributor

@amberry amberry commented Mar 1, 2025

This brings supported list to be vscode, windsurf and cursor

Vscode and cursor can install the ms remote extension, and so the extensionpack entry triggers that.

The ms remote ssh extension is not available for the gallery that windsurf has, so that dep becomes invisible there, and then the activation code does the right thing for Windsurf, using its built in remote support.

Tabling vscodium support for now, had some issues (hanging on attempting to start the remote) I didn't get to the bottom of between this coder extension and https://open-vsx.org/extension/jeanp413/open-remote-ssh.

Addresses #408

@matifali matifali requested review from bcpeinhardt and f0ssel March 1, 2025 06:39
@amberry amberry changed the title Support windsurf and vscodium setups for coder extension Support windsurf setups for coder extension Mar 6, 2025
@matifali
Copy link
Member

matifali commented Mar 6, 2025

Hi @amberry, with the previous information and my testing.

Windsurf

Works without any issues.

VSCodium

Works if jeanp413.open-remote-ssh is pre-installed and we launch from URI, i.e., vscodium://...
But can not render the Coder extension views
image

Also, manual login from the Coder extension gives
`command 'coder.login' not found

Cursor

The cursor only works if the remote-ssh extension is pre-installed. The coder extension now does not prompt you to install it.

@amberry
Copy link
Contributor Author

amberry commented Mar 6, 2025

@matifali Yep, I updated the description to state that windsurf, vscode and cursor do work.

Now, re cursor. If you installed a locally built vsix package, then the extensionpack deps don't get installed, thats a platform limitation.

Screenshot 2025-03-06 at 4 35 57 PM

Once built and hosted on a marketplace the extensionpack deps will come through, and I did check that with a marketplace running locally (I have one because of other work I'm doing). If they are valid for the marketplace gallery defined, you'll see them on the extension pack tab above ^.

@f0ssel f0ssel requested a review from matifali March 7, 2025 15:01
@matifali
Copy link
Member

matifali commented Mar 7, 2025

Tabling vscodium support for now, had some issues (hanging on attempting to start the remote) I didn't get to the bottom of between this coder extension and open-vsx.org/extension/jeanp413/open-remote-ssh.

For me, VSCodium works fine if https://open-vsx.org/extension/jeanp413/open-remote-ssh is installed. I am fine if we consider that as a separate PR.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amberry
I will leave the final approval for @bcpeinhardt.

@bcpeinhardt bcpeinhardt merged commit 9ee582b into coder:main Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants