Skip to content

Commit

Permalink
[CALCITE-1192] Clarify date/time serialization methods
Browse files Browse the repository at this point in the history
Addendum: Make sure the json and protobuf docs are consistent
in their descriptions about how they are serialized as numbers.
  • Loading branch information
joshelser committed Apr 18, 2016
1 parent e010b1b commit 6ddd782
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions avatica/site/_docs/json_reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -1177,10 +1177,10 @@ for more information on valid attributes in JSON.
| DOUBLE | number ||
| BIG_INTEGER | number | Implicitly handled by Jackson. |
| BIG_DECIMAL | number | Implicitly handled by Jackson. |
| JAVA_SQL_TIME | number | As an integer, millis since midnight. |
| JAVA_SQL_DATE | number | As an integer, days since the epoch. |
| JAVA_SQL_TIMESTAMP | number | As a long, millis since the epoch. |
| JAVA_UTIL_DATE | number | As a long, millis since the epoch. |
| JAVA_SQL_TIME | number | As an integer, milliseconds since midnight. |
| JAVA_SQL_DATE | number | As an integer, the number of days since the epoch. |
| JAVA_SQL_TIMESTAMP | number | As a long, milliseconds since the epoch. |
| JAVA_UTIL_DATE | number | As a long, milliseconds since the epoch. |
| BYTE_STRING | string | A Base64-encoded string. |
| STRING | string | |
| NUMBER | number | A general number, unknown what concrete type. |
Expand Down
8 changes: 4 additions & 4 deletions avatica/site/_docs/protobuf_reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -1251,10 +1251,10 @@ to the attributes in this message:
| DOUBLE | `number_value` ||
| BIG_INTEGER | `bytes_value` | The two's-complement representation of the BigInteger. See `BigInteger#toByteArray().` |
| BIG_DECIMAL | `string_value` | A string-ified representation of the value. See `BigDecimal#toString()`. |
| JAVA_SQL_TIME | `number_value` ||
| JAVA_SQL_DATE | `number_value` ||
| JAVA_SQL_TIMESTAMP | `number_value` ||
| JAVA_UTIL_DATE | `number_value` ||
| JAVA_SQL_TIME | `number_value` | As an integer, milliseconds since midnight. |
| JAVA_SQL_DATE | `number_value` | As an integer, the number of days since the epoch. |
| JAVA_SQL_TIMESTAMP | `number_value` | As a long, milliseconds since the epoch. |
| JAVA_UTIL_DATE | `number_value` | As a long, milliseconds since the epoch. |
| BYTE_STRING | `bytes_value` ||
| STRING | `string_value` | This must be a UTF-8 string. |
| NUMBER | `number_value` | A general number, unknown what concrete type. |
Expand Down

0 comments on commit 6ddd782

Please sign in to comment.