Skip to content

Commit

Permalink
Fix check for wxACC_STATE_SYSTEM_MARQUEED in accessibility code
Browse files Browse the repository at this point in the history
wxACC_STATE_SYSTEM_INVISIBLE was checked twice, by mistake, while
wxACC_STATE_SYSTEM_MARQUEED was never checked at all.

Thanks to PVS-Studio for finding this issue (V581: The conditional expressions
of the 'if' operators situated alongside each other are identical).
  • Loading branch information
IlyaPVS authored and vadz committed Apr 29, 2017
1 parent d5c46e8 commit 5d7726e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/msw/ole/access.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2037,8 +2037,8 @@ long wxConvertToWindowsState(long wxstate)
if (wxstate & wxACC_STATE_SYSTEM_INVISIBLE)
state |= STATE_SYSTEM_INVISIBLE;

if (wxstate & wxACC_STATE_SYSTEM_INVISIBLE)
state |= STATE_SYSTEM_INVISIBLE;
if (wxstate & wxACC_STATE_SYSTEM_MARQUEED)
state |= STATE_SYSTEM_MARQUEED;

if (wxstate & wxACC_STATE_SYSTEM_MIXED)
state |= STATE_SYSTEM_MIXED;
Expand Down

0 comments on commit 5d7726e

Please sign in to comment.