Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Update mission statement #324

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Update mission statement #324

merged 3 commits into from
Nov 21, 2018

Conversation

shahednasser
Copy link
Contributor

@shahednasser shahednasser commented Nov 21, 2018

What kind of change does this PR introduce

This PR updates the mission text as requested in this issue

What is the current behavior

The text shows "On a mission to improve the state of tech across India"

What is the new behavior

The text shows "On a mission to improve the state of Tech Education across India"

Checklist for this PR

  • I have read contributing guidelines.
  • I executed yarn lint locally to format my code.
  • I added revelant Tests to verify my code. N/A
  • All tests yarn test ran successfully.
  • Pull request is towards develop branch.
  • I have tested responsiveness of the UI by checking on devices using ScreenFly N/A
  • Added myself to contributors table
  • Documentation N/A
  • Ready to be merged

I also had to fix the line height for the h1 tag holding the text.

@welcome
Copy link

welcome bot commented Nov 21, 2018

Thanks so much for opening your first PR here!

@coderplex-bot
Copy link
Collaborator

coderplex-bot commented Nov 21, 2018

Deploy preview for coderplex ready!

Built with commit 9866b81

https://deploy-preview-324--coderplex.netlify.com

@vinaypuppal
Copy link
Contributor

@shahednasser

I also had to fix the line height for the h1 tag holding the text.

Instead of this, can you reduce font-size a bit so, on large screens this text remains on a single line

@shahednasser
Copy link
Contributor Author

@vinaypuppal sure I'll do that.

@vinaypuppal vinaypuppal merged commit 85d6164 into coderplex-org:develop Nov 21, 2018
@welcome
Copy link

welcome bot commented Nov 21, 2018

🎉 🎉 🎊 Congrats on merging your first pull request! We here at coderplex.org are proud of you!. If you believe in our 📃 mission statement please ⭐ us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants