Fixes assistants going to medium priority when other job is selected (t…

…gstation#65645)
cogh0020 · Mar 25, 2022 · 5a1fa40 · 5a1fa40
1 parent 15f31a0
commit 5a1fa40
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/code/modules/client/preferences.dm b/code/modules/client/preferences.dm
@@ -442,9 +442,16 @@ INITIALIZE_IMMEDIATE(/atom/movable/screen/character_preview_view)
 		return FALSE
 
 	if (level == JP_HIGH)
+		var/datum/job/overflow_role = SSjob.overflow_role
+		var/overflow_role_title = initial(overflow_role.title)
+
 		for(var/other_job in job_preferences)
 			if(job_preferences[other_job] == JP_HIGH)
-				job_preferences[other_job] = JP_MEDIUM
+				// Overflow role needs to go to NEVER, not medium!
+				if(other_job == overflow_role_title)
+					job_preferences[other_job] = null
+				else
+					job_preferences[other_job] = JP_MEDIUM
 
 	job_preferences[job.title] = level