Skip to content

Commit

Permalink
Merge branch 'canary' of github.com:zeit/next.js into canary
Browse files Browse the repository at this point in the history
  • Loading branch information
timneutkens committed Mar 31, 2018
2 parents c07cf5e + b39958e commit 43fe9ac
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
8 changes: 2 additions & 6 deletions examples/with-firebase-hosting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,9 @@ npm run dev

#### Run Firebase locally for testing:

Unfortunately I have been unable to get any combination of

```bash
firebase serve --only functions,hosting
```

to locally host the built Next.js app as expected. [This issue is where solutions are being explored](https://github.com/firebase/firebase-tools/issues/535) and they will be shared here and on the [Next.js repo's similar issue](https://github.com/zeit/next.js/issues/3167) when discovered.
npm run serve
```

#### Deploy it to the cloud with Firebase:

Expand Down
2 changes: 1 addition & 1 deletion examples/with-firebase-hosting/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Host Next.js SSR app on Firebase Cloud Functions with Firebase Hosting redirects.",
"scripts": {
"dev": "next src/app",
"serve": "echo \"for details see:\n\thttps://github.com/firebase/firebase-tools/issues/535 \n\thttps://github.com/zeit/next.js/issues/3167\";",
"serve": "NODE_ENV=production firebase serve --only functions,hosting",
"deploy": "firebase deploy",
"clean": "rimraf \"dist/functions\" && rimraf \"dist/public\"",
"build-public": "cpx \"src/public/**/*.*\" \"dist/public\" -C",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"fresh": "0.5.2",
"friendly-errors-webpack-plugin": "1.6.1",
"glob": "7.1.2",
"hoist-non-react-statics": "2.3.1",
"hoist-non-react-statics": "2.5.0",
"htmlescape": "1.1.1",
"http-errors": "1.6.2",
"http-status": "1.0.1",
Expand Down

0 comments on commit 43fe9ac

Please sign in to comment.