Skip to content

Commit

Permalink
Disable flaky goto definition testcase until fixed (FuelLabs#4228)
Browse files Browse the repository at this point in the history
## Description

Disabling this test since it's failing on a lot of PRs. Will re-enable
it once it's fixed.

Related FuelLabs#4211

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
  • Loading branch information
sdankel authored Mar 7, 2023
1 parent 2b26e19 commit 04ff513
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions sway-lsp/tests/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -842,17 +842,18 @@ async fn go_to_definition_for_paths() {
let _ = lsp::definition_check(&mut service, &go_to, &mut i).await;
definition_check_with_req_offset(&mut service, &mut go_to, 25, 31, &mut i).await;

let go_to = GotoDefinition {
req_uri: &uri,
req_line: 6,
req_char: 39,
def_line: 2,
def_start_char: 7,
def_end_char: 15,
def_path: "sway-lsp/tests/fixtures/tokens/paths/src/deep_mod/deeper_mod.sw",
};
// TODO: Uncomment when https://github.com/FuelLabs/sway/issues/4211 is fixed.
// let go_to = GotoDefinition {
// req_uri: &uri,
// req_line: 6,
// req_char: 39,
// def_line: 2,
// def_start_char: 7,
// def_end_char: 15,
// def_path: "sway-lsp/tests/fixtures/tokens/paths/src/deep_mod/deeper_mod.sw",
// };
// dfun
let _ = lsp::definition_check(&mut service, &go_to, &mut i).await;
// let _ = lsp::definition_check(&mut service, &go_to, &mut i).await;

shutdown_and_exit(&mut service).await;
}
Expand Down

0 comments on commit 04ff513

Please sign in to comment.