Improve performance of AbstractInstructionSet::verify(self) (FuelLa…

…bs#3898) This brings down the call to `AbstractInstructionSet::verify(self)` from > `70s` to `30ms` (> 2000X improvement) in https://github.com/sway-libs/concentrated-liquidity/ Co-authored-by: João Matos <[email protected]>
cold-briu · Jan 26, 2023 · dd95780 · dd95780
1 parent 61d96de
commit dd95780
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/sway-core/src/asm_generation/fuel/abstract_instruction_set.rs b/sway-core/src/asm_generation/fuel/abstract_instruction_set.rs
@@ -12,10 +12,7 @@ use crate::{
 use sway_error::error::CompileError;
 use sway_types::Span;
 
-use std::{
-    collections::{BTreeSet, HashSet},
-    fmt,
-};
+use std::{collections::HashSet, fmt};
 
 use either::Either;
 
@@ -134,12 +131,12 @@ impl AbstractInstructionSet {
             ($regs: expr, $set: expr) => {
                 let mut regs = $regs;
                 regs.retain(|&reg| matches!(reg, VirtualRegister::Virtual(_)));
-                $set.append(&mut regs);
+                $set.extend(regs.into_iter());
             };
         }
 
-        let mut use_regs = BTreeSet::new();
-        let mut def_regs = BTreeSet::new();
+        let mut use_regs = HashSet::new();
+        let mut def_regs = HashSet::new();
         for op in &self.ops {
             add_virt_regs!(op.use_registers(), use_regs);
             add_virt_regs!(op.def_registers(), def_regs);