Present the warning only when the files open in the editor relate to …

…the project being worked on for the following actions
cold11 · Mar 9, 2021 · 0141d95 · 0141d95
1 parent 6936118
commit 0141d95
Show file tree

Hide file tree

Showing 12 changed files with 108 additions and 23 deletions.
diff --git a/SDLTranscreate/SDLTranscreate/Actions/ConvertProjectAction.cs b/SDLTranscreate/SDLTranscreate/Actions/ConvertProjectAction.cs
@@ -39,6 +39,23 @@ public class ConvertProjectAction : AbstractAction
 
 		protected override void Execute()
 		{
+			var selectedProject = _controllers.ProjectsController.SelectedProjects.FirstOrDefault();
+			if (selectedProject == null)
+			{
+				return;
+			}
+
+			var documents = _controllers.EditorController.GetDocuments()?.ToList();
+			if (documents != null && documents.Count > 0)
+			{
+				var documentProjectIds = documents.Select(a => a.Project.GetProjectInfo().Id.ToString()).Distinct();
+				if (documentProjectIds.Any(a => a == selectedProject.GetProjectInfo().Id.ToString()))
+				{
+					MessageBox.Show(PluginResources.Wanring_Message_CloseAllProjectDocumentBeforeProceeding, PluginResources.TranscreateManager_Name, MessageBoxButton.OK, MessageBoxImage.Information);
+					return;
+				}
+			}
+
 			// set the default settings for creating the xliff from the sdlxliff
 			// these should not be taken from the users settings
 			var settings = GetSettings();
@@ -54,15 +71,22 @@ protected override void Execute()
 			var action = Enumerators.Action.Convert;
 			var workFlow = Enumerators.WorkFlow.Internal;
 
-			var selectedProject = _controllers.ProjectsController.SelectedProjects.FirstOrDefault();
-			var newProjectLocalFolder = selectedProject?.GetProjectInfo().LocalProjectFolder + "-T";
+
+			var newProjectLocalFolder = selectedProject.GetProjectInfo().LocalProjectFolder + "-T";
 			if (Directory.Exists(newProjectLocalFolder))
 			{
 				MessageBox.Show(PluginResources.Warning_Message_ProjectFolderAlreadyExists + Environment.NewLine + Environment.NewLine + newProjectLocalFolder, 
 					PluginResources.Plugin_Name, MessageBoxButton.OK, MessageBoxImage.Information);
 				return;
 			}
 
+			if (selectedProject.GetProjectInfo().ProjectOrigin == Constants.ProjectOrigin_TranscreateProject)
+			{
+				MessageBox.Show(PluginResources.Warning_Message_ProjectAlreadyTranscreateProject,
+					PluginResources.Plugin_Name, MessageBoxButton.OK, MessageBoxImage.Information);
+				return;
+			}
+
 			var wizardService = new WizardService(action, workFlow, _pathInfo, _customerProvider,
 				_imageService, _controllers, _segmentBuilder, settings, _dialogService, 
 				_projectAutomationService, _projectSettingsService);
@@ -73,7 +97,7 @@ protected override void Execute()
 				MessageBox.Show(message, PluginResources.Plugin_Name, MessageBoxButton.OK, MessageBoxImage.Information);
 				return;
 			}
-
+		
 			_controllers.TranscreateController.UpdateProjectData(taskContext);
 		}
 
@@ -123,7 +147,15 @@ private void ProjectsController_SelectedProjectsChanged(object sender, System.Ev
 
 		private void SetEnabled()
 		{
-			Enabled = _controllers.ProjectsController.SelectedProjects.Count() == 1;
+			if (_controllers.ProjectsController.SelectedProjects.Count() != 1)
+			{
+				Enabled = false;
+				return;
+			}
+
+			var selectedProject = _controllers.ProjectsController.SelectedProjects.FirstOrDefault();
+
+			Enabled = selectedProject?.GetProjectInfo().ProjectOrigin != Constants.ProjectOrigin_TranscreateProject;
 		}
 	}
 }
diff --git a/SDLTranscreate/SDLTranscreate/Actions/CreateBackTranslationAction.cs b/SDLTranscreate/SDLTranscreate/Actions/CreateBackTranslationAction.cs
@@ -51,14 +51,25 @@ protected override void Execute()
 			{
 				return;
 			}
-
+			
 			var studioProject = _controllers.ProjectsController.GetProjects()
 				.FirstOrDefault(a => a.GetProjectInfo().Id.ToString() == project.Id);
 			if (studioProject == null)
 			{
 				return;
 			}
 
+			var documents = _controllers.EditorController.GetDocuments()?.ToList();
+			if (documents != null && documents.Count > 0)
+			{
+				var documentProjectIds = documents.Select(a => a.Project.GetProjectInfo().Id.ToString()).Distinct();
+				if (documentProjectIds.Any(a => a == project.Id))
+				{
+					MessageBox.Show(PluginResources.Wanring_Message_CloseAllProjectDocumentBeforeProceeding, PluginResources.TranscreateManager_Name, MessageBoxButton.OK, MessageBoxImage.Information);
+					return;
+				}
+			}
+
 			var action = Enumerators.Action.CreateBackTranslation;
 			var workFlow = Enumerators.WorkFlow.Internal;
 
@@ -142,7 +153,7 @@ private void ProjectsController_SelectedProjectsChanged(object sender, ProjectSe
 			SetEnabled(e.SelectedProject);
 		}
 
-		private void SetEnabled(Interfaces.IProject selectedProject)
+		private void SetEnabled(IProject selectedProject)
 		{
 			Enabled = selectedProject is Project && !(selectedProject is BackTranslationProject);
 		}

diff --git a/SDLTranscreate/SDLTranscreate/Actions/ExportAction.cs b/SDLTranscreate/SDLTranscreate/Actions/ExportAction.cs
@@ -43,6 +43,17 @@ protected override void Execute()
 				return;
 			}
 
+			var documents = _controllers.EditorController.GetDocuments()?.ToList();
+			if (documents != null && documents.Count > 0)
+			{
+				var documentProjectIds = documents.Select(a => a.Project.GetProjectInfo().Id.ToString()).Distinct();
+				if (documentProjectIds.Any(a => a == selectedProject.Id))
+				{
+					MessageBox.Show(PluginResources.Wanring_Message_CloseAllProjectDocumentBeforeProceeding, PluginResources.TranscreateManager_Name, MessageBoxButton.OK, MessageBoxImage.Information);
+					return;
+				}
+			}
+
 			var action = selectedProject is BackTranslationProject
 				? Enumerators.Action.ExportBackTranslation
 				: Enumerators.Action.Export;
@@ -92,7 +103,7 @@ public override void Initialize()
 			_projectAutomationService = new ProjectAutomationService(
 				_imageService, _controllers.TranscreateController, _controllers.ProjectsController, _customerProvider, _studioVersionService);
 			_projectSettingsService = new ProjectSettingsService();
-			
+
 			Enabled = false;
 		}
 

diff --git a/SDLTranscreate/SDLTranscreate/Actions/ImportAction.cs b/SDLTranscreate/SDLTranscreate/Actions/ImportAction.cs
@@ -43,6 +43,17 @@ protected override void Execute()
 				return;
 			}
 
+			var documents = _controllers.EditorController.GetDocuments()?.ToList();
+			if (documents != null && documents.Count > 0)
+			{
+				var documentProjectIds = documents.Select(a => a.Project.GetProjectInfo().Id.ToString()).Distinct();
+				if (documentProjectIds.Any(a => a == selectedProject.Id))
+				{
+					MessageBox.Show(PluginResources.Wanring_Message_CloseAllProjectDocumentBeforeProceeding, PluginResources.TranscreateManager_Name, MessageBoxButton.OK, MessageBoxImage.Information);
+					return;
+				}
+			}
+
 			var action = selectedProject is BackTranslationProject
 				? Enumerators.Action.ImportBackTranslation
 				: Enumerators.Action.Import;

diff --git a/SDLTranscreate/SDLTranscreate/Common/Constants.cs b/SDLTranscreate/SDLTranscreate/Common/Constants.cs
@@ -4,5 +4,6 @@ public class Constants
 	{
 		public static string OriginSystem_TranscreateAutomation = "Transcreate Automation";
 		public static string ProjectOrigin_TranscreateProject = "Transcreate project";
+		public static string ProjectOrigin_BackTranslationProject = "Back-Translation project";
 	}
 }
diff --git a/SDLTranscreate/SDLTranscreate/PluginResources.Designer.cs b/SDLTranscreate/SDLTranscreate/PluginResources.Designer.cs
diff --git a/SDLTranscreate/SDLTranscreate/PluginResources.resx b/SDLTranscreate/SDLTranscreate/PluginResources.resx
@@ -737,7 +737,7 @@
 	  <value>Open folder in explorer?</value>
   </data>
   <data name="Message_TranscreateReportsCreatedSuccessfully" xml:space="preserve">
-	  <value>The transcreate reports have been created successfully.</value>
+	  <value>The Transcreate reports have been created successfully.</value>
   </data>
   <data name="Warning_Message_ProjectFolderAlreadyExists" xml:space="preserve">
 	  <value>The project folder already exists!</value>
@@ -748,4 +748,10 @@
   <data name="Warning_Message_ProjectNameSuffixCannotBeNull" xml:space="preserve">
 	  <value>The project name suffix cannot be null!</value>
   </data>
+  <data name="Warning_Message_ProjectAlreadyTranscreateProject" xml:space="preserve">
+	  <value>The project has already been converted to a Transcreate project.</value>
+  </data>
+  <data name="Wanring_Message_CloseAllProjectDocumentBeforeProceeding" xml:space="preserve">
+	  <value>Close all documents from the editor that are associated with the selected project before proceeding.</value>
+  </data>
 </root>
diff --git a/SDLTranscreate/SDLTranscreate/Properties/AssemblyInfo.cs b/SDLTranscreate/SDLTranscreate/Properties/AssemblyInfo.cs
@@ -32,4 +32,4 @@
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
 [assembly: AssemblyVersion("2.0.0.0")]
-[assembly: AssemblyFileVersion("2.0.4.9")]
+[assembly: AssemblyFileVersion("2.0.4.10")]
diff --git a/SDLTranscreate/SDLTranscreate/Service/ProjectAutomationService.cs b/SDLTranscreate/SDLTranscreate/Service/ProjectAutomationService.cs
@@ -240,7 +240,7 @@ public async Task<FileBasedProject> CreateBackTranslationProject(FileBasedProjec
 				SourceLanguage = newSourceLanguage,
 				TargetLanguages = new Language[] { newTargetLanguage },
 				DueDate = projectInfo.DueDate,
-				ProjectOrigin = "Back-Translation project",
+				ProjectOrigin = Constants.ProjectOrigin_BackTranslationProject,
 				IconPath = iconPath
 			};
 
@@ -528,7 +528,7 @@ private bool LanguageExistsIn(List<Language> values, string value, bool ignoreCa
 
 		private bool IsBackTranslationProject(string projectOrigin)
 		{
-			return string.Compare(projectOrigin, "Back-Translation project",
+			return string.Compare(projectOrigin, Constants.ProjectOrigin_BackTranslationProject,
 				StringComparison.CurrentCultureIgnoreCase) == 0;
 		}
 

diff --git a/SDLTranscreate/SDLTranscreate/Service/WizardService.cs b/SDLTranscreate/SDLTranscreate/Service/WizardService.cs
@@ -75,14 +75,6 @@ public TaskContext ShowWizard(AbstractController controller, out string message)
 				return null;
 			}
 
-			var documents = _controllers.EditorController.GetDocuments();
-			if (documents.Any())
-			{
-				message = PluginResources.WizardMessage_CloseOpenDocumentsInTheEditor;
-				return null;
-			}
-
-
 			_isCancelled = false;
 			_wizardWindow = new WizardWindow();
 			_wizardWindow.Loaded += WizardWindowLoaded;

diff --git a/SDLTranscreate/SDLTranscreate/TranscreateViewController.cs b/SDLTranscreate/SDLTranscreate/TranscreateViewController.cs
@@ -262,7 +262,10 @@ public void UpdateProjectData(TaskContext taskContext)
 
 			if (taskContext.Project.Id != _projectsController.CurrentProject?.GetProjectInfo().Id.ToString())
 			{
-				_projectAutomationService.ActivateProject(fileBasedProject);
+				lock (_lockObject)
+				{
+					_projectAutomationService.ActivateProject(fileBasedProject);
+				}
 			}
 
 			var sourceLanguage = taskContext.Project.SourceLanguage.CultureInfo.Name;
@@ -1016,7 +1019,7 @@ private string GetRelativePath(string projectPath, string path)
 
 		private bool IsBackTranslationProject(string projectOrigin)
 		{
-			return string.Compare(projectOrigin, "Back-Translation project",
+			return string.Compare(projectOrigin, Constants.ProjectOrigin_BackTranslationProject,
 				StringComparison.CurrentCultureIgnoreCase) == 0;
 		}
 

diff --git a/SDLTranscreate/SDLTranscreate/pluginpackage.manifest.xml b/SDLTranscreate/SDLTranscreate/pluginpackage.manifest.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PluginPackage xmlns="http://www.sdl.com/Plugins/PluginPackage/1.0">
 	<PlugInName>Trados Transcreate</PlugInName>
-	<Version>2.0.4.9</Version>
+	<Version>2.0.4.10</Version>
 	<Description>Trados Transcreate is a plugin for Trados Studio designed to help manage the Transcreation process.</Description>
 	<Author>Community Developers</Author>
 	<RequiredProduct name="SDLTradosStudio" minversion="16.1" />