Skip to content

Commit

Permalink
Update CONTRIBUTING.md to account for buildroot (flutter#2893)
Browse files Browse the repository at this point in the history
  • Loading branch information
abarth authored Aug 9, 2016
1 parent 9c09565 commit 0392945
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
22 changes: 11 additions & 11 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Getting the code and configuring your environment
solutions = [
{
"managed": False,
"name": "src",
"name": "src/flutter",
"url": "[email protected]:<your_name_here>/engine.git",
"custom_deps": {},
"deps_file": "DEPS",
Expand Down Expand Up @@ -74,7 +74,7 @@ dependency_overrides:
Run the following steps, from the `src` directory created in the steps above:

* `gclient sync` to update your dependencies.
* `./sky/tools/gn --android --unoptimized` to prepare your build files.
* `./flutter/tools/gn --android --unoptimized` to prepare your build files.
* `ninja -C out/android_debug_unopt` to actually build the Android binary.

This builds a debug-enabled ("unoptimized") binary configured to run Dart in
Expand Down Expand Up @@ -116,7 +116,7 @@ to test the engine.

* Make sure you have Xcode 7.3.0+ installed.
* `gclient sync` to update dependencies.
* `./sky/tools/gn --ios --unoptimized` to prepare build files.
* `./flutter/tools/gn --ios --unoptimized` to prepare build files.
* For a discussion on the various flags and modes, [read this discussion](https://github.com/flutter/flutter/wiki/Flutter's-modes).
* `ninja -C out/ios_debug_unopt` to build iOS artifacts.

Expand All @@ -131,7 +131,7 @@ Once the artifacts are built, you can start using them in your application by fo
### Desktop (Mac and Linux), for tests

* `gclient sync` to update your dependencies.
* `./sky/tools/gn` to prepare your build files.
* `./flutter/tools/gn` to prepare your build files.
* `ninja -C out/host_debug_unopt` to build a desktop unoptimized binary.

To run the tests, you'll also need to clone [the main Flutter repository](https://github.com/flutter/flutter).
Expand All @@ -150,13 +150,13 @@ git fetch upstream
git rebase upstream/master
gclient sync

sky/tools/gn --unoptimized --runtime-mode=debug
sky/tools/gn --android --unoptimized --runtime-mode=debug
sky/tools/gn --android --unoptimized --runtime-mode=profile
sky/tools/gn --android --unoptimized --runtime-mode=release
sky/tools/gn --android --runtime-mode=debug
sky/tools/gn --android --runtime-mode=profile
sky/tools/gn --android --runtime-mode=release
flutter/tools/gn --unoptimized --runtime-mode=debug
flutter/tools/gn --android --unoptimized --runtime-mode=debug
flutter/tools/gn --android --unoptimized --runtime-mode=profile
flutter/tools/gn --android --unoptimized --runtime-mode=release
flutter/tools/gn --android --runtime-mode=debug
flutter/tools/gn --android --runtime-mode=profile
flutter/tools/gn --android --runtime-mode=release

cd out
ls | xargs -n 1 ninja -C
Expand Down
2 changes: 1 addition & 1 deletion sky/tools/gn → tools/gn
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import subprocess
import sys
import os

SRC_ROOT = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))))
SRC_ROOT = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))

def get_out_dir(args):
if args.target_os is not None:
Expand Down
File renamed without changes.

0 comments on commit 0392945

Please sign in to comment.