Skip to content

Commit

Permalink
add support for PHI nodes to ObjectSizeOffsetVisitor
Browse files Browse the repository at this point in the history
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@171298 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
nunoplopes committed Dec 31, 2012
1 parent 6931055 commit 729e602
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 3 deletions.
17 changes: 14 additions & 3 deletions lib/Analysis/MemoryBuiltins.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -535,9 +535,20 @@ SizeOffsetType ObjectSizeOffsetVisitor::visitLoadInst(LoadInst&) {
return unknown();
}

SizeOffsetType ObjectSizeOffsetVisitor::visitPHINode(PHINode&) {
// too complex to analyze statically.
return unknown();
SizeOffsetType ObjectSizeOffsetVisitor::visitPHINode(PHINode &PHI) {
if (PHI.getNumIncomingValues() == 0)
return unknown();

SizeOffsetType Ret = compute(PHI.getIncomingValue(0));
if (!bothKnown(Ret))
return unknown();

// verify that all PHI incoming pointers have the same size and offset
for (unsigned i = 1, e = PHI.getNumIncomingValues(); i != e; ++i) {
if (compute(PHI.getIncomingValue(i)) != Ret)
return unknown();
}
return Ret;
}

SizeOffsetType ObjectSizeOffsetVisitor::visitSelectInst(SelectInst &I) {
Expand Down
54 changes: 54 additions & 0 deletions test/Transforms/InstCombine/objsize.ll
Original file line number Diff line number Diff line change
Expand Up @@ -256,3 +256,57 @@ xpto:
return:
ret i32 7
}

declare noalias i8* @valloc(i32) nounwind

; CHECK: @test14
; CHECK: ret i32 6
define i32 @test14(i32 %a) nounwind {
switch i32 %a, label %sw.default [
i32 1, label %sw.bb
i32 2, label %sw.bb1
]

sw.bb:
%call = tail call noalias i8* @malloc(i32 6) nounwind
br label %sw.epilog

sw.bb1:
%call2 = tail call noalias i8* @calloc(i32 3, i32 2) nounwind
br label %sw.epilog

sw.default:
%call3 = tail call noalias i8* @valloc(i32 6) nounwind
br label %sw.epilog

sw.epilog:
%b.0 = phi i8* [ %call3, %sw.default ], [ %call2, %sw.bb1 ], [ %call, %sw.bb ]
%1 = tail call i32 @llvm.objectsize.i32(i8* %b.0, i1 false)
ret i32 %1
}

; CHECK: @test15
; CHECK: llvm.objectsize
define i32 @test15(i32 %a) nounwind {
switch i32 %a, label %sw.default [
i32 1, label %sw.bb
i32 2, label %sw.bb1
]

sw.bb:
%call = tail call noalias i8* @malloc(i32 3) nounwind
br label %sw.epilog

sw.bb1:
%call2 = tail call noalias i8* @calloc(i32 2, i32 1) nounwind
br label %sw.epilog

sw.default:
%call3 = tail call noalias i8* @valloc(i32 3) nounwind
br label %sw.epilog

sw.epilog:
%b.0 = phi i8* [ %call3, %sw.default ], [ %call2, %sw.bb1 ], [ %call, %sw.bb ]
%1 = tail call i32 @llvm.objectsize.i32(i8* %b.0, i1 false)
ret i32 %1
}

0 comments on commit 729e602

Please sign in to comment.