Fix alibaba#119

confid917 · Oct 9, 2018 · 074d6aa · 074d6aa
1 parent 55433f0
commit 074d6aa
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/config/src/main/java/com/alibaba/nacos/config/server/service/LocalDataSourceServiceImpl.java b/config/src/main/java/com/alibaba/nacos/config/server/service/LocalDataSourceServiceImpl.java
@@ -178,19 +178,23 @@ private List<String> loadSql(String sqlFile) throws Exception {
      * @param sqlFile sql
      * @throws Exception Exception
      */
-    public void execute(Connection conn, String sqlFile) throws Exception {
+    private void execute(Connection conn, String sqlFile) throws Exception {
         Statement stmt = null;
-        List<String> sqlList = loadSql(sqlFile);
-        stmt = conn.createStatement();
-        for (String sql : sqlList) {
-            try {
-                stmt.execute(sql);
-            } catch (Exception e) {
-                LogUtil.defaultLog.info(e.getMessage());
+        try {
+            List<String> sqlList = loadSql(sqlFile);
+            stmt = conn.createStatement();
+            for (String sql : sqlList) {
+                try {
+                    stmt.execute(sql);
+                } catch (Exception e) {
+                    LogUtil.defaultLog.info(e.getMessage());
+                }
+            }
+        } finally {
+            if (stmt != null) {
+                stmt.close();
             }
-
         }
-        stmt.close();
     }
 
 	public static String getAppHome() {