Fix: An Error SQL will make server down (ClickHouse#1388)

congwen · Oct 23, 2017 · d8038cf · d8038cf
1 parent dd45194
commit d8038cf
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/dbms/src/DataTypes/DataTypeArray.cpp b/dbms/src/DataTypes/DataTypeArray.cpp
@@ -403,7 +403,7 @@ Field DataTypeArray::getDefault() const
 
 static DataTypePtr create(const ASTPtr & arguments)
 {
-    if (arguments->children.size() != 1)
+    if (!arguments || arguments->children.size() != 1)
         throw Exception("Array data type family must have exactly one argument - type of elements", ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH);
 
     DataTypePtr nested_type = DataTypeFactory::instance().get(arguments->children[0]);

diff --git a/dbms/tests/queries/0_stateless/00507_array_no_params.reference b/dbms/tests/queries/0_stateless/00507_array_no_params.reference
@@ -0,0 +1 @@
+Still alive
diff --git a/dbms/tests/queries/0_stateless/00507_array_no_params.sh b/dbms/tests/queries/0_stateless/00507_array_no_params.sh
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+. $CURDIR/../shell_config.sh
+
+$CLICKHOUSE_CLIENT -q "DROP TABLE IF EXISTS test.foo;"
+# Missing arguments for array, table not created
+$CLICKHOUSE_CLIENT -q "CREATE TABLE test.foo (a Array) Engine=Memory;"
+$CLICKHOUSE_CLIENT -q "SELECT 'Still alive';"