-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jin Dong as a reviewer #138
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Danny Canter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM. Welcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
And thanks to the community for all the guidance and feedback/reviews! Look forward to continuing my contributions to the community and learning more from everyone :)
Woo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jin has been an extremely active contributor to the daemon and nerdctl. His review comments are insightful and his contributions always meet our high quality standards. I propose we add him as a reviewer to the project as it feels overdue 😄.
New reviewers require a 1/3 vote of committers. From 11 committers, 4 must approve + new reviewer: