Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jin Dong as a reviewer #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dcantah
Copy link
Member

@dcantah dcantah commented Feb 5, 2025

Jin has been an extremely active contributor to the daemon and nerdctl. His review comments are insightful and his contributions always meet our high quality standards. I propose we add him as a reviewer to the project as it feels overdue 😄.

New reviewers require a 1/3 vote of committers. From 11 committers, 4 must approve + new reviewer:

Signed-off-by: Danny Canter <[email protected]>
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kzys
Copy link
Member

kzys commented Feb 5, 2025

LGTM. Welcome!

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome

Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

And thanks to the community for all the guidance and feedback/reviews! Look forward to continuing my contributions to the community and learning more from everyone :)

@dcantah
Copy link
Member Author

dcantah commented Feb 6, 2025

Woo!

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants