Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the current schema #744

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

cgwalters
Copy link
Collaborator

There's...a variety of warts in the current API schema. In particular I really dislike .image.image.image.

But...but...changing it now would in practice be somewhat difficult, and it's hard to say that just that tweak would be really useful.

Let's just stabilize the existing spec as v1 and commit to maintaining it.

We've already added notes to ask callers to use --format-version 1 to specify what they want so we can compatibly add new things in the future.

Speaking of, this also makes --format-version=1 be the same thing as --format-version=0 so that all the versions are just "1".

Closes: #518

There's...a variety of warts in the current API schema.
In particular I really dislike `.image.image.image`.

But...but...changing it now would in practice be somewhat
difficult, and it's hard to say that just *that* tweak
would be really useful.

Let's just stabilize the existing spec as `v1` and commit
to maintaining it.

We've already added notes to ask callers to use `--format-version 1`
to specify what they want so we can compatibly add new things
in the future.

Speaking of, this also makes `--format-version=1` be the
same thing as `--format-version=0` so that all the versions
are just "1".

Closes: containers#518

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters enabled auto-merge July 31, 2024 19:29
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit 94e5bc4 into containers:main Jul 31, 2024
27 of 28 checks passed
cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 5, 2024
…d-ext-4.0.3

build(deps): bump cap-std-ext from 4.0.2 to 4.0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec/status stabilization
2 participants