Fix serialdump.c #1048
Merged
Fix serialdump.c #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge yet. There is a patch to come. |
|
May I propose to make 115200 default instead of 57600 while you're at it? 115200 seems to be the de facto standard for most platforms. |
|
@msloth There you go. :) |
|
Good to have a clean up of serialdump, but on a first look I noticed that the PR adds a space after some of the |
_GNU_SOURCE is needed for O_DIRECT time.h is needed for strftime
|
Very welcome fix and cleanup, and it seems @nvt's comment is addressed, so 👍 from me |
|
👍 as well, one less argument to my aliases :-) |
simonduq
added a commit
that referenced
this pull request
May 15, 2015
Fix and clean up serialdump.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_GNU_SOURCE is needed for O_DIRECT
time.h is needed for strftime