add support for gke node group (and update waiter) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The waiter will continue waiting when the nodes are ready. I had pointed this out and wrote a custom funciton and it got replaced by the waiter at some point. :/ this will revert it back, but I need to test it first./ Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
This is still risky to do - the GKE clusters self update and often render in a state that is not usable. But this is still better than the current setup. When I am brave I will try bringing this up again. Another issue here is by using a region, we set a min/max for EACH region so it can result in 3-4x the number of nodes that are expected (not a great surprise imho). Signed-off-by: vsoch <[email protected]>
vsoch
changed the title
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
the function could work again in the future. Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The waiter will continue waiting when the nodes are ready. I had pointed this out and wrote a custom function and it got replaced by the waiter at some point. :/ this will revert it back, but I need to test it first.